Skip to content

RAC: swap custom outline variant for ui library secondary #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
microbit-matt-hillsdon merged 2 commits into from
Aug 11, 2026
Merged

RAC: swap custom outline variant for ui library secondary #1254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04ca3ce
Use the library's `secondary` for the default button variant
microbit-matt-hillsdon Aug 11, 2026
ea75cd0
Bump private preset for brand.50 stop
microbit-matt-hillsdon Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- run: npm ci
env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- run: npm install --no-save @microbit-foundation/python-editor-v3-microbit@0.2.0-experiment.rai.66 @microbit-foundation/website-deploy-aws@0.6.0 @microbit-foundation/website-deploy-aws-config@0.9.0 @microbit-foundation/circleci-npm-package-versioner@1
- run: npm install --no-save @microbit-foundation/python-editor-v3-microbit@0.2.0-experiment.rai.67 @microbit-foundation/website-deploy-aws@0.6.0 @microbit-foundation/website-deploy-aws-config@0.9.0 @microbit-foundation/circleci-npm-package-versioner@1
if: github.repository_owner == 'microbit-foundation'
env:
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
8 changes: 0 additions & 8 deletions src/deployment/default/panda-preset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,6 @@ export const appPreset = definePreset({
button: {
variants: {
variant: {
outline: {
borderWidth: "2px",
borderColor: "currentColor",
color: "brand.500",
bg: "transparent",
_hover: { color: "brand.600", bg: "transparent" },
},
// Icon buttons on the app's dark chrome (sidebar header,
// serial bar): white glyph, white pill on hover. The Chakra
// variant was ghost-based with callers passing color="white";
Expand Down Expand Up @@ -143,7 +136,6 @@ export const appPreset = definePreset({
},
},
},
defaultVariants: { variant: "outline" },
},
},
},
Expand Down
6 changes: 3 additions & 3 deletions src/simulator/SimulatorActionBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ const SimulatorActionBar = ({
>
<IconButton
size={size}
variant="outline"
variant="secondary"
onPress={() => handleStop("user")}
aria-label={intl.formatMessage({ id: "simulator-stop" })}
isDisabled={running === RunningStatus.STOPPED}
Expand All @@ -101,7 +101,7 @@ const SimulatorActionBar = ({
</IconButton>
<IconButton
size={size}
variant="outline"
variant="secondary"
onPress={device.reset}
aria-label={intl.formatMessage({ id: "simulator-reset" })}
isDisabled={running === RunningStatus.STOPPED}
Expand All @@ -110,7 +110,7 @@ const SimulatorActionBar = ({
</IconButton>
<IconButton
size={size}
variant="outline"
variant="secondary"
onPress={handleMuteUnmute}
aria-label={
isMuted
Expand Down
Loading