Replace lodash with local sortBy and debounce utilities - #1285
Merged
Conversation
We only used sortBy and debounce, both in their simplest form (function iteratees, trailing-edge debounce with no cancel/flush). The per-method packages we depended on (lodash.debounce, lodash.sortby) are deprecated upstream, so rather than migrating to lodash-es we replace them with small tested utilities in src/common. Also simplifies sortByStart in the search worker code, whose hand-rolled sort existed only to avoid pulling lodash into the worker bundle.
|
Preview build will be at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only used sortBy and debounce, both in their simplest form (function iteratees, trailing-edge debounce with no cancel/flush). The per-method packages we depended on (lodash.debounce, lodash.sortby) are deprecated upstream, so rather than migrating to lodash-es we replace them with small tested utilities in src/common.
Also simplifies sortByStart in the search worker code, whose hand-rolled sort existed only to avoid pulling lodash into the worker bundle.