Correct node link #66
Conversation
Fixes indentation. Normalizes spacing between elements.
Replaces right quotation mark with apostrophe contractions.
While quotation marks must be escaped in some places, e.g., in attribute values, they are allowed in html content. For the json example, no escaping is needed, and using direct characters makes reading the source easier.
Like the previous commit. This commit replaces escape quotation marks with the real thing, making the code more readable.
Replaces link from glenjones/.. to microformats/...
There was a problem hiding this comment.
This doesn't seem correct. This links the Node library button to this repo. AFAIK https://github.com/glennjones/microformat-node is still the correct repo for the Node library?
|
Could you also update the node.microformats.io website link to https: https://node.microformats.io/ |
|
A link from the website to itself? Did you mean a link from https://microformats.io to https://node.microformats.io/? (And not a link from node .microformats.io....) |
| <form action="https://ruby.microformats.io/microformats" accept-charset="UTF-8" method="get" class="form -inline mt-3 mb-3"> | ||
| <input name="utf8" type="hidden" value="✓"> | ||
| <p>Production ready parsers are available for: <a href="https://go.microformats.io">Go</a>, <a | ||
| href="http://node.microformats.io">Node</a>, <a href="https://php.microformats.io">PHP</a>, <a |
There was a problem hiding this comment.
Could you make this link https?
There was a problem hiding this comment.
@gRegorLove since the status of this PR can't be resolved until microformats/microformats-parser-website-node#4 is resolved, I've created a separate PR to fix links: #69.
| @@ -261,7 +261,7 @@ <h2>Parser Libraries</h2> | |||
| </div> | |||
| <div class="col-4 col-sm-2 language language-node"> | |||
| <a class="btn btn-secondary btn-sm" href="http://node.microformats.io">Website</a> | |||
| <a class="btn btn-secondary btn-sm" href="https://github.com/glennjones/microformat-node">Library</a> | |||
| <a class="btn btn-secondary btn-sm" href="https://github.com/microformats/microformats.io">Library</a> | |||
There was a problem hiding this comment.
Need to double-check this. AFAIK https://github.com/glennjones/microformat-node is the correct link to the Node library. This change here is linking "Library" to the microformats.io library, which is not correct.
|
No, this repository, microformats.io. Added inline comments above. |
|
Regarding #66 (review) There are (as I learned today) two mf node parser libraries: There was a request in the chat to change the link from the first to the second. That second is a Typescript parser. I don't know if they are different. Or which one should be on the site. I understood the chat to be a request to change it. The conversation about this is in the chat archives, starting at 17:10 on 2022-12-14 Maybe I was wrong. |
|
Yes, I can change the link to https. |
|
From the yarn.lock, it appears to be glennjones/microformat-node. |
|
Well then something was misunderstood. Maybe the chat meant change the node website parser to use the Typescript parser, then change the link. |
|
Resolution will depend on microformats/microformats-parser-website-node#4 |
|
@gRegorLove I converted this to draft. I suspect it will be at least a bit of time before any change to the node website is made. And as I mentioned yesterday, PR #69 corrects the links (not just the one you pointed out; there were many http; links to the mf wiki that should be https:). |
No description provided.