Fix v2 licensing #3084
Open
Fix v2 licensing #3084
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to latest
com.pairip.licensecheckbehavior, the third parameter in the licensing v2 call is actually an integer and not a Bundle. I've tested this with current apps that feature v2 licensing, namelyorg.howwefeel.moodmeterandfr.maif.digital.maifetmoi(note: closes on emulator, but console log from the app indicate that license check is successful).Regardless, I've verified against https://github.com/e-foundation/lvl-sample that it still works if an empty bundle is passed.
Related: https://gitlab.e.foundation/e/os/backlog/-/issues/3730
Special thanks to @prplwtf.