Skip to content

Issue4 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Issue4 #7

wants to merge 2 commits into from

Conversation

n76
Copy link
Contributor

@n76 n76 commented May 17, 2016

MapQuest requires a developer API key now and there is no reasonable way to provide a paid one with sufficient capacity to handle all the requests from Nominatim. So this patch provides a way for the end user to use their own developer API key which for low volume use they can get for free.

This is analogous to the situation that CyanogenMod is running into with their weather widget as discussed at http://www.cyanogenmod.org/blog/plug-play-weather and the solution has been to make plug-ins for possible service providers and have the plug-ins configurable by the user to use their own key.

n76 added 2 commits May 17, 2016 02:59
MapQuest now requires a developer API key to be used when querying their
Nominatim server. This change allows the end user to enter a key that
they can get without charge from the MapQuest developer site at

https://developer.mapquest.com

Signed-off-by: Tod Fitch <[email protected]>
Android Studio was too helpful in suggesting changes and automatically editing
the manifest.

Signed-off-by: Tod Fitch <[email protected]>
@alinefr
Copy link

alinefr commented Jun 11, 2016

Thank you! It's working.

@alanpoulain
Copy link

It's working well, thanks. Would be great to merge.

@Teyro
Copy link

Teyro commented Aug 4, 2016

@alinefr @alanpoulain Can you sent me the working apk? teyro [at] posteo.de ? Would help me much!

@zoff99
Copy link

zoff99 commented Aug 4, 2016

#9
with comands to build on circle CI

@Teyro
Copy link

Teyro commented Aug 4, 2016

@zoff99 Thx but i am to stupid to compile by myself :S

@zoff99
Copy link

zoff99 commented Aug 4, 2016

why yourself? circleCI is compiling for you

https://circleci.com/gh/zoff99/NominatimGeocoderBackend/17#artifacts

just fork mine, and login to https://circleci.com with your github login

@ale5000-git
Copy link
Member

Hi,
is it possible to have it without bumping minSdkVersion?

@be-neth
Copy link
Contributor

be-neth commented Jan 28, 2017

@ale5000-git It is not possible because it uses getFragmentManager() which is available since API 11.

https://developer.android.com/reference/android/app/FragmentManager.html

@ale5000-git
Copy link
Member

@be-neth: Sorry, I didn't noticed your reply here before.

@mar-v-in
Copy link
Member

Closed via #14

@mar-v-in mar-v-in closed this Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants