Skip to content

readme: clarify installation instructions #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

readme: clarify installation instructions #146

wants to merge 1 commit into from

Conversation

David-Guillot
Copy link

@David-Guillot David-Guillot commented Jan 4, 2018

  • ADB commands directly as Shell snippets
  • Move Nougat to a separate case, since the KK/L/M procedure doesn't work

This change is Reviewable

* ADB commands directly as Shell snippets
* Move Nougat to a separate case, since the KK/L/M procedure doesn't work
@ale5000-git
Copy link
Member

It isn't true, the procedure for Nougat is the same as for other, there are just additional steps but the base is the same.

@David-Guillot
Copy link
Author

The additional step you referring to (which i suppose is to apply the signature patch) is:

  • neither properly documented (i just don't know what to type on my keyboard)
  • nor acceptable from my perspective since Nougat is about to become the most widely used version of Android (and is probably already the most used AOSP version in the community of people installing custom ROMs) ; IMHO the most used version is supposed to be the rule, not the exception that you handle with a patch

This is why i decided to go for a manual ADB install (which is slightly different from KK/L/M because you apparently have to put the APK in a subfolder of priv-app, but i'm not sure about that, i read that on some blog posts), and then to share my experience through this README ;)

@ale5000-git
Copy link
Member

ale5000-git commented Jan 5, 2018

L and M is the same of N regarding the folder.

@JonnyTech
Copy link

To confirm, placing the file at /system/priv-app/microg.apk works on L, M, N and O.

@ale5000-git
Copy link
Member

ale5000-git commented Jan 5, 2018

It works but it is only for compatibility I think.
Since Lollipop the structure is changed and who know for how much time the old structure will still work.

@David-Guillot
Copy link
Author

Thanks @ale5000-git for the clarifications about the subfolder thing, i was not really sure.

@mar-v-in , what do you think about all this?

@mar-v-in
Copy link
Member

mar-v-in commented Jan 5, 2018

I guess it's better to use adb remount instead of adb mount /system, no?

@ale5000-git
Copy link
Member

ale5000-git commented Jan 5, 2018

I haven't tried but I don't think adb mount /system is even working, bwt too much separation will lead to more errors when it need to be updated.
This evening I will see if I can make it more clear for all Android versions.

@David-Guillot
Copy link
Author

Actually i replaced adb remount by adb mount /system because the former was not working with my configuration (Nougat, ADB from recovery). adb root && adb remount did not mount /system.

@ale5000-git
Copy link
Member

ale5000-git commented Jan 5, 2018

I think it should be adb shell mount /system (instead of adb mount /system), bwt remount doesn't mount as read-write if not already mounted (as read-only or read-write) as mount doesn't remount as read-write (if it was read-only).

The command depend of what is needed.

ale5000-git added a commit to ale5000-git/android_packages_apps_UnifiedNlp that referenced this pull request Jan 6, 2018
Merged info for all Android versions to have a global idea
Make it usable when the device is inside the recovery or inside the system
Added separate adb commands for various Android versions
Added info for Oreo
Added Déjà Vu Location Service

(Based on pull request microg#146 by @David-Guillot)
@ale5000-git ale5000-git mentioned this pull request Jan 6, 2018
@ale5000-git
Copy link
Member

What do you think of this change? #147

@David-Guillot
Copy link
Author

Actually @ale5000-git i don't really understand why you created another PR for this 😕. If some things don't seem clear enough in mine, i can fix it...

@ale5000-git
Copy link
Member

ale5000-git commented Jan 8, 2018

Because I have taken a completely different approach; I have still credited you in the message

@David-Guillot
Copy link
Author

Closing this as #147 seems more relevant, and the project doesn't seem maintained (i'm just cleaning up my Github :P ). Thanks @ale5000-git for credit in your PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants