refactor: use for loop replace spread to fix stack overflow

[zzuu666]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and discussions and couldn’t find anything or linked relevant results below
• I made sure the docs are up to date
• I included tests (or that’s not needed)

Description of changes

Main change is use for replace w/ spread opreator [...slice]

When I try to parse a large markdown file, about 1.6 Mb, I meet an issue RangeError: Maximum call stack size exceeded

I debugged the source code and found that the error came from the slice line. I suspected that the spread operator caused the stack overflow.

After, change it to for, the issue has fixed.

[codecov]

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

[ChristianMurphy]

Adding a loop could could significant negative performance impact.
Could concat be used instead?

See:
micromark/micromark#187
micromark/micromark@acc135e

[zzuu666]

I try to use Array.contact to replace for loop, but the event is a parameter, I just can modify it in-place, do you have any recommend, thx.

[ChristianMurphy]

Better than a comment, would be a test that fails with the current logic and passes after

[zzuu666]

I add a large markdown file to test/fixtures, it will fail when run the original codes.

[ChristianMurphy]

Thanks, could we remove this comment now, since the test will cover it?

[ChristianMurphy]

Thanks, could we remove this comment now, since the test will cover it?

[zzuu666]

sure, I have removed unnecessary comment, thank you for the review and your time

[wooorm]

thanks, released in 2.1.1!