Skip to content
This repository was archived by the owner on Oct 20, 2023. It is now read-only.

Conversation

@dxlr8r
Copy link

@dxlr8r dxlr8r commented Jun 27, 2023

Complete with automatic configuration reloading etc.

This was referenced Jun 27, 2023
@mischah
Copy link
Collaborator

mischah commented Jun 28, 2023

Thanks for your contribution :octocat: ❤️

I’m going to add @samhocevar and @chclaus as reviewer to potentially merge this.

P.S. This will close #54

@mischah mischah requested review from chclaus and samhocevar June 28, 2023 05:24
@dxlr8r
Copy link
Author

dxlr8r commented Jun 28, 2023

I've been thinking, I think I want to replace "write" with "create". What we want to restrict is creating of directories and files. Right now, the code disallows truncation and modification/alteration of existing files as well (given it matches).

When I get the time, I'll look into it.

… while allowing other, truncation, write etc.
@dxlr8r
Copy link
Author

dxlr8r commented Jun 29, 2023

When I get the time, I'll look into it.

Done, see new commit

@dxlr8r
Copy link
Author

dxlr8r commented Aug 1, 2023

Are the reviewers alive?

@chclaus
Copy link
Collaborator

chclaus commented Aug 3, 2023

Hej @dxlr8r,

thanks for the PR. @samhocevar could you review it? Otherwise I'll try my best next week. ;)

@chclaus
Copy link
Collaborator

chclaus commented Aug 12, 2023

Hej,

the week is gone. Sorry for the missing merge. I'm on vacatio. without any hardware.

I promise: I'll take care of it next week. 😉

Copy link
Collaborator

@chclaus chclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thanks for this great PR! Can you please adjust the indentation depth in the Readme? Then this strong piece of code is merged! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants