fix(nanopush): panic on GoAwayError code path#248
Merged
Conversation
MagnusHJensen
changed the title
2 tasks
jessepeterson
approved these changes
Apr 8, 2026
Member
There was a problem hiding this comment.
Good catch. However I think this makes the assumption that r==nil if err!=nil. Seems unlikely to be a relevant response if there's an error, but that's a potential gap we'd be missing. In any case: this seems fine. We can address if we wanted r.StatusCode; or maybe have a fallback.
Contributor
Author
|
Yeah, based on my dive into the code (and slight exploration into the net/http) I had a hard time finding a case where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a subtle (and most likely never hit) code panic.
The code path in the nanopush provider, used the r.StatusCode, which is not available. I'm not sure if we are okay with the error being built assumes it's an HTTP status code, but we instead pass the GoAway error code.