Skip to content

Add support for AWS CRT Client #2434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
driverpt wants to merge 10 commits into
base: 4.12.x
Choose a base branch
from
Open

Add support for AWS CRT Client #2434

driverpt wants to merge 10 commits into from

Conversation

@driverpt
Copy link
Contributor

@driverpt driverpt commented Nov 21, 2025 •
edited
Loading

@driverpt driverpt force-pushed the add-aws-crt-client-support branch from 45d55ed to 742f364 Compare November 21, 2025 11:26
@driverpt driverpt marked this pull request as ready for review November 21, 2025 11:36
@driverpt
Copy link
Contributor Author

driverpt commented Nov 21, 2025

Build is failing due to some issue with Kotlin and J25

@graemerocher graemerocher requested a review from sdelamo November 21, 2025 13:55
@sdelamo sdelamo removed this from 4.10.3 Release Dec 2, 2025
@sdelamo
Copy link
Contributor

sdelamo commented Dec 2, 2025

target 4.12.x as base please

@driverpt driverpt changed the base branch from 5.0.x to 4.12.x December 2, 2025 12:30
@driverpt driverpt requested a review from sdelamo December 2, 2025 12:34
@driverpt
Copy link
Contributor Author

driverpt commented Dec 2, 2025

target 4.12.x as base please

done

@driverpt driverpt force-pushed the add-aws-crt-client-support branch from bce65fe to afc4d4b Compare December 2, 2025 14:05
@driverpt
Copy link
Contributor Author

driverpt commented Dec 2, 2025 

* What went wrong:
Could not determine the dependencies of task ':test-suite-kotlin:compileKotlin'.
> Cannot find a Java installation on your machine (Linux 6.11.0-1018-azure amd64) matching: {languageVersion=17, vendor=any vendor, implementation=vendor-specific, nativeImageCapable=false}. Toolchain download repositories have not been configured.

@sdelamo
Copy link
Contributor

sdelamo commented Dec 2, 2025 

* What went wrong:
Could not determine the dependencies of task ':test-suite-kotlin:compileKotlin'.
> Cannot find a Java installation on your machine (Linux 6.11.0-1018-azure amd64) matching: {languageVersion=17, vendor=any vendor, implementation=vendor-specific, nativeImageCapable=false}. Toolchain download repositories have not been configured.

I just merged 4.12.x into the PR. That should solve that issue.

sdelamo
sdelamo requested changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test fail with

Message: Multiple possible bean candidates found: [SdkAsyncHttpClient, SdkAsyncHttpClient]

The issue is both NettyClientFactory::nettyClient and AwsCrtFactory::awsCrtClient create clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdelamo sdelamo sdelamo requested changes

Assignees

No one assigned

Labels

None yet

Projects

4.10.4 Release
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@driverpt @sdelamo