Feature/Support for QueryValue as a object #11787
Conversation
|
|
|
@dstepanov can you think of a better way to do this? otherwise i think it's ok |
| BeanIntrospection<T> introspection = introspectionOpt.get(); | ||
| T instance; | ||
| try { | ||
| instance = introspection.instantiate(); |
There was a problem hiding this comment.
Why no-args constructor is required? I'think you need more tests with record and required args constructor (without no-arg)
| return BindingResult.unsatisfied(); | ||
| } | ||
|
|
||
| BeanIntrospection<T> introspection = introspectionOpt.get(); |
There was a problem hiding this comment.
this should be altered to use introspection.builder() so that records, immutable types, types with custom constructors etc. are supported.
There was a problem hiding this comment.
When using IntrospectionBuilder API and finally call the build() method any exception should b caught and the conversion rejected with context.reject
There was a problem hiding this comment.
I made the changes with the introspection.builder(). Seems to work for object with custom constructor but I made a test for record and don't work. Am I missing something?
…s, types with custom constructors etc.
http/src/main/java/io/micronaut/http/bind/binders/QueryValueArgumentBinder.java
Show resolved
Hide resolved
| BeanIntrospection<T> introspection = introspectionOpt.get(); | ||
| BeanIntrospection.Builder<T> introspectionBuilder = introspection.builder(); | ||
|
|
||
| for (BeanProperty<T, Object> property : introspection.getBeanProperties()) { |
There was a problem hiding this comment.
iterative here over the getBuilderArguments() using array iteration to obtain the index
http/src/main/java/io/micronaut/http/bind/binders/QueryValueArgumentBinder.java
Outdated
Show resolved
Hide resolved
http/src/main/java/io/micronaut/http/bind/binders/QueryValueArgumentBinder.java
Outdated
Show resolved
Hide resolved
| Optional<Object> converted = conversionService.convert(value.get(), context.with(property.asArgument())); | ||
| if (converted.isPresent()) { | ||
| try { | ||
| introspectionBuilder.with(propertyName, converted.get()); |
There was a problem hiding this comment.
invoke with passing the index from the array iteration https://docs.micronaut.io/latest/api/io/micronaut/core/beans/BeanIntrospection.Builder.html#with(int,io.micronaut.core.type.Argument,A)
There was a problem hiding this comment.
I tried with getBuilderArguments() iteration, still not working for the records
No description provided.