Refactor multipart #12246
Draft
Refactor multipart #12246
+4,475
−1,919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard netty multipart decoder is quite buggy. A new API is available at https://github.com/netty-contrib/codec-multipart . That implementation also has compatible drop-in replacement for the old netty APIs. This PR checks whether the new implementation is available on the classpath, and if so, uses that instead of standard netty. There is also a config option to enable "quirks" that restore various bugs of the old implementation for compatibility. This is experimental and undocumented because the new API is in alpha. I've added it to 4.10 to let people resolve long-standing issues with form data parsing.
* Add support for less buggy multipart decoder The standard netty multipart decoder is quite buggy. A new API is available at https://github.com/netty-contrib/codec-multipart . That implementation also has compatible drop-in replacement for the old netty APIs. This PR checks whether the new implementation is available on the classpath, and if so, uses that instead of standard netty. There is also a config option to enable "quirks" that restore various bugs of the old implementation for compatibility. This is experimental and undocumented because the new API is in alpha. I've added it to 4.10 to let people resolve long-standing issues with form data parsing. * handle new exception types * handle new exception types v2 * fix dealloc0
) Description This PR adds configurable maxHeaderListSize property to HTTP client configuration for HTTP2. Added maxHeaderListSize configuration property with getter/setter methods. Updated Http2FrameCodec instantiation to use the configurable header list size. Considerations Can be configured via micronaut.http.client.http2.max-header-list-size property.
# Conflicts: # buffer-netty/src/main/java/io/micronaut/buffer/netty/NettyReadBufferFactory.java # core/src/main/java/io/micronaut/core/execution/ImperativeExecutionFlowImpl.java # core/src/main/java/io/micronaut/core/io/buffer/ReadBufferFactory.java # http-netty/src/main/java/io/micronaut/http/netty/body/AvailableNettyByteBody.java # http-server-netty/src/main/java/io/micronaut/http/server/netty/NettyHttpRequest.java # http-server-netty/src/main/java/io/micronaut/http/server/netty/binders/NettyPartUploadAnnotationBinder.java # http-server-netty/src/main/java/io/micronaut/http/server/netty/configuration/NettyHttpServerConfiguration.java # http-server-netty/src/main/java/io/micronaut/http/server/netty/multipart/MultipartBodyArgumentBinder.java # http/src/main/java/io/micronaut/http/BasicHttpAttributes.java # http/src/main/java/io/micronaut/http/multipart/StreamingFileUpload.java
# Conflicts: # gradle.properties # http-server-netty/build.gradle.kts # http-server-netty/src/main/java/io/micronaut/http/server/netty/configuration/NettyHttpServerConfiguration.java
# Conflicts: # core/src/main/java/io/micronaut/core/io/buffer/NioReadBuffer.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.