Skip to content

Return error on QueryValue conversion failures #12321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
iamsb97 wants to merge 2 commits into
base: 4.10.x
Choose a base branch
from
Open

Return error on QueryValue conversion failures #12321

iamsb97 wants to merge 2 commits into from
+104 −11

Conversation

@iamsb97
Copy link
Contributor

@iamsb97 iamsb97 commented Jan 9, 2026

Fixes #12238.

Change summary:

  1. Return BindingResult with error on conversion failures instead of BindingResult.unsatisfied().
  2. Move error cases into separate tests and verify error messages.
  3. Add new tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@iamsb97