Conversation
|
dstepanov
force-pushed
the
jakartadata
branch
2 times, most recently
from
f5a87f7 to
d4d9533
Compare
dstepanov
force-pushed
the
jakartadata
branch
2 times, most recently
from
374c649 to
f1cb09a
Compare
|
@dstepanov target 4.13.x? |
|
Yes, going to work on it |
| @Internal | ||
| @Singleton | ||
| @Requires(classes = OptimisticLockingFailureException.class) | ||
| final class HibernateJakartaDataDeleteExceptionConverter implements JakartaDataDeleteExceptionConverter { |
There was a problem hiding this comment.
does it make sense to move these converters into a registrar?
There was a problem hiding this comment.
No, it's different kind of converter
| int size = getSize(); | ||
| return size == 0 ? 1 : (int) Math.ceil((double) getTotalSize() / (double) size); | ||
| long totalSize = getTotalSize(); | ||
| if (totalSize == -1) { |
There was a problem hiding this comment.
we should document this breaking change somewhere
There was a problem hiding this comment.
Reverted, looks like it's not needed
| */ | ||
| @NonNull | ||
| @JsonIgnore | ||
| default Limit getLimit() { |
There was a problem hiding this comment.
make sure to test serialization and deserialisation
data-model/src/main/java/io/micronaut/data/model/PersistentProperty.java
Show resolved
Hide resolved
...odel/src/main/java/io/micronaut/data/model/jpa/criteria/PersistentEntityCriteriaBuilder.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Execute tests with a Persistence specific entity with a repository that requires read and writes (AKA not read-only) | ||
| */ | ||
| @Property(name = "jpa.default.properties.hibernate.show_sql", value = "true") |
There was a problem hiding this comment.
Does this property have effect since this is jdbc module? It's just a bit confusing to me.
Also, would it be possible to have jakarta_data tests for other dialects as well?
There was a problem hiding this comment.
Yeah I copy-pasted it. I don't think we need to test other dialect variations
|
4 participants
No description provided.