Skip to content

Conversation

caioguedes
Copy link

Fixes #34

The icon file was extracted from the main page of the documentation.

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2023

CLA assistant check
All committers have signed the CLA.

@sdelamo
Copy link
Contributor

sdelamo commented Jan 26, 2024

do we have a favicon.ico you are referencing in this PR?
I assume we will have to copy https://micronaut.io/wp-content/uploads/2021/02/favicon.ico in the img folder

@sdelamo sdelamo closed this Jan 26, 2024
@sdelamo sdelamo reopened this Jan 26, 2024
@caioguedes
Copy link
Author

do we have a favicon.ico you are referencing in this PR? I assume we will have to copy https://micronaut.io/wp-content/uploads/2021/02/favicon.ico in the img folder

Exactly, I extracted the icon from the main page https://micronaut.io/wp-content/uploads/2021/02/favicon.ico, do we should point the icon to this url or the raw url in the git repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

favicon is missing from user guide

3 participants