generated from micronaut-projects/micronaut-project-template
-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Improve Attachment Model with FileAttachment and InlineAttachment (#554) #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vin-it-9
wants to merge
8
commits into
micronaut-projects:3.0.x
Choose a base branch
from
Vin-it-9:feature/type-safe-attachments
base: 3.0.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
edc2d14
feat: Introduce type-safe email attachments with FileAttachment and I…
Vin-it-9 7fed179
feat: Add type-safe attachment methods to Email.Builder for FileAttac…
Vin-it-9 be64005
test: Add comprehensive specs for type-safe email attachments and leg…
Vin-it-9 b901387
refactor(email): clean up Attachment and ContentId, add constant, con…
Vin-it-9 4afbade
added javadoc for isInline method
Vin-it-9 f4db88a
Merge branch '3.0.x' into feature/type-safe-attachments
Vin-it-9 20b8768
Update email/src/main/java/io/micronaut/email/ContentId.java
Vin-it-9 f1b11da
feat: ContentId with null safety and add tests for attachment inline …
Vin-it-9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /* | ||
| * Copyright 2017-2025 original authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.micronaut.email; | ||
|
|
||
| import io.micronaut.core.annotation.NonNull; | ||
|
|
||
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * Value type for an RFC 2392 Content-ID, used for inline email attachments. | ||
| * | ||
| * Instances represent the identifier part of a Content-ID header (without | ||
| * surrounding angle brackets). Use {@link #toHeaderValue()} to obtain a header-safe | ||
| * representation (with < and >). | ||
| * | ||
| * @since 3.0.0 | ||
| */ | ||
| public record ContentId(@NonNull String value) { | ||
|
|
||
| public ContentId { | ||
| Objects.requireNonNull(value, "ContentId value must not be null"); | ||
| } | ||
|
|
||
Vin-it-9 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| /** | ||
| * Returns the formatted header value suitable for use in a Content-ID header. | ||
| * | ||
| * For example, a value of {@code "img-1"} will be returned as {@code "<img-1>"}. | ||
| * | ||
| * @return the header formatted content id, never {@code null} | ||
| */ | ||
| @NonNull | ||
| public String toHeaderValue() { | ||
Vin-it-9 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return "<" + value + ">"; | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
email/src/main/java/io/micronaut/email/EmailAttachment.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| * Copyright 2017-2025 original authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.micronaut.email; | ||
|
|
||
| import io.micronaut.core.annotation.NonNull; | ||
|
|
||
| /** | ||
| * Strongly typed email attachment. Use {@link FileAttachment} for regular files, | ||
| * or {@link InlineAttachment} for embedded inline content. | ||
| * | ||
| * @author Vinit Shinde | ||
| * @since 3.0.0 | ||
| */ | ||
| public sealed interface EmailAttachment | ||
| permits FileAttachment, InlineAttachment { | ||
|
|
||
| /** | ||
| * The filename as shown in the client's download/save dialogs. | ||
| * | ||
| * @return the filename | ||
| */ | ||
| @NonNull | ||
| String getFilename(); | ||
|
|
||
| /** | ||
| * The attachment's content as bytes. | ||
| * | ||
| * @return the content bytes | ||
| */ | ||
| @NonNull | ||
| byte[] getContent(); | ||
|
|
||
| /** | ||
| * The MIME type for the content. | ||
| * | ||
| * @return the MIME type | ||
| */ | ||
| @NonNull | ||
| String getContentType(); | ||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.