fix: @JsonIgnore to JsonFeedAuthor::isEmpty

jsonfeed-core/build.gradle.kts

@@ -0,0 +1,14 @@
+plugins {
+    id("io.micronaut.build.internal.rss-module")
+}
+
+dependencies {
+    annotationProcessor(mnValidation.micronaut.validation.processor)
+    implementation(mnValidation.micronaut.validation)
+    api(mn.jackson.annotations)
+    api(mn.micronaut.inject)
+    api(projects.micronautRssLanguage)
+    testImplementation(mn.micronaut.jackson.databind)
+    testImplementation(mn.groovy.json)
+    testImplementation(mn.micronaut.http.client)
+}

jsonfeed-core/src/main/java/io/micronaut/rss/jsonfeed/JsonFeedAuthor.java

@@ -15,6 +15,7 @@
  */
 package io.micronaut.rss.jsonfeed;
 
+import com.fasterxml.jackson.annotation.JsonIgnore;
 import io.micronaut.core.annotation.NonNull;
 import io.micronaut.core.annotation.Nullable;
 import io.micronaut.core.annotation.Introspected;
@@ -115,6 +116,7 @@ public void setAvatar(@Nullable String avatar) {
      *
      * @return true if all author's, name, url and avatar are empty or null.
      */
+    @JsonIgnore
     public boolean isEmpty() {
         return StringUtils.isEmpty(this.avatar) &&
             StringUtils.isEmpty(this.url) &&

jsonfeed-core/src/test/groovy/io/micronaut/rss/jsonfeed/ApplicationContextSpecification.groovy

@@ -1,7 +1,7 @@
 package io.micronaut.rss.jsonfeed
 
 import io.micronaut.context.ApplicationContext
-import io.micronaut.serde.ObjectMapper
+import io.micronaut.json.JsonMapper
 import spock.lang.AutoCleanup
 import spock.lang.Shared
 import spock.lang.Specification
@@ -18,5 +18,5 @@ abstract class ApplicationContextSpecification extends Specification implements
     Validator validator = applicationContext.getBean(Validator)
 
     @Shared
-    ObjectMapper objectMapper = applicationContext.getBean(ObjectMapper)
+    JsonMapper objectMapper = applicationContext.getBean(JsonMapper)
 }

jsonfeed-core/src/test/groovy/io/micronaut/rss/jsonfeed/JsonFeedAuthorSpec.groovy

@@ -1,8 +1,30 @@
 package io.micronaut.rss.jsonfeed
 
+import io.micronaut.context.ApplicationContext
 import io.micronaut.core.beans.BeanIntrospection
+import io.micronaut.json.JsonMapper
 
 class JsonFeedAuthorSpec extends ApplicationContextSpecification {
+
+    void "JsonFeedAuthor serialization"() {
+        given:
+        ApplicationContext ctx = ApplicationContext.run()
+        JsonMapper jsonMapper = ctx.getBean(JsonMapper)
+        JsonFeedAuthor author = JsonFeedAuthor.builder()
+                .name("John Doe")
+                .url("mailto:[email protected]")
+                .avatar("https://staging.storage.noticeable.io/users/1hvH7RWx9CWe8QCskAHBcsgpbkF2/01h5m04a42c02czp09khyrx3bm-avatar.png")
+                .build()
+        when:
+        String json = jsonMapper.writeValueAsString(author)
+
+        then:
+        json
+        !json.contains("empty")
+
+        cleanup:
+        ctx.close()
+    }
     void "JsonFeedAuthor is annotated with Introspected"() {
         when:
         BeanIntrospection.getIntrospection(JsonFeedAuthor)

settings.gradle

@@ -18,6 +18,7 @@ include 'itunespodcast'
 include 'jsonfeed-core'
 include 'jsonfeed'
 include 'rss-language'
+include 'test-suite'
 
 enableFeaturePreview 'TYPESAFE_PROJECT_ACCESSORS'
 

test-suite/build.gradle.kts

@@ -0,0 +1,18 @@
+plugins {
+    `java-library`
+}
+repositories {
+    mavenCentral()
+}
+dependencies {
+    testImplementation(project(":micronaut-jsonfeed-core"))
+    testAnnotationProcessor(mn.micronaut.inject.java)
+    testAnnotationProcessor(mnSerde.micronaut.serde.processor)
+    testImplementation(mnSerde.micronaut.serde.jackson)
+    testImplementation(mnTest.micronaut.test.junit5)
+    testRuntimeOnly(mnTest.junit.jupiter.engine)
+    testRuntimeOnly(mnLogging.logback.classic)
+}
+tasks.withType<Test> {
+    useJUnitPlatform()
+}

test-suite/src/test/java/io/micronaut/rss/jsonfeed/JsonFeedAuthorTest.java

@@ -0,0 +1,25 @@
+package io.micronaut.rss.jsonfeed;
+
+import io.micronaut.json.JsonMapper;
+import io.micronaut.test.extensions.junit5.annotation.MicronautTest;
+import org.junit.jupiter.api.Test;
+
+import java.io.IOException;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
+@MicronautTest(startApplication = false)
+class JsonFeedAuthorTest {
+    @Test
+    void jsonFeedAuthorSerialization(JsonMapper jsonMapper) throws IOException {
+        JsonFeedAuthor author = JsonFeedAuthor.builder()
+            .name("John Doe")
+            .url("mailto:[email protected]")
+            .avatar("https://staging.storage.noticeable.io/users/1hvH7RWx9CWe8QCskAHBcsgpbkF2/01h5m04a42c02czp09khyrx3bm-avatar.png")
+            .build();
+        String json = jsonMapper.writeValueAsString(author);
+        assertNotNull(json);
+        assertFalse(json.contains("empty"));
+    }
+}

test-suite/src/test/resources/logback.xml

@@ -0,0 +1,10 @@
+<configuration>
+    <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
+        <encoder>
+            <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</pattern>
+        </encoder>
+    </appender>
+    <root level="info">
+        <appender-ref ref="STDOUT" />
+    </root>
+</configuration>