Fixed bug where consul container always starts at port 8500. #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld never be the norm, it should default to a custom port instead. This fixes that issue and automatically sets the defaultZone, which was also missing.
|
Bump - I had to add some more logic on my local one to property see the DefaultZone for the health checks. I have it working on my other branch, I'll soon push an update to it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where consul container always starts at port 8500. That should never be the norm, it should default to a custom port instead. This fixes that issue and automatically sets the defaultZone, which was also missing.
Also, automatically filled out the default zone, which should fix the "bug" where it discovery couldn't work with this container because it must be 8500 (which would be a bug outside this project, which caused my dev environment to be wiped out ;) )
Anyway, it works now - and the test still tests agaisnt the allocated port so no change needed to happen in the tests