Skip to content

Fixed bug where consul container always starts at port 8500. #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.8.x
Choose a base branch
from

Conversation

krickert
Copy link
Contributor

@krickert krickert commented May 4, 2025

Fixed bug where consul container always starts at port 8500. That should never be the norm, it should default to a custom port instead. This fixes that issue and automatically sets the defaultZone, which was also missing.

Also, automatically filled out the default zone, which should fix the "bug" where it discovery couldn't work with this container because it must be 8500 (which would be a bug outside this project, which caused my dev environment to be wiped out ;) )

Anyway, it works now - and the test still tests agaisnt the allocated port so no change needed to happen in the tests

…uld never be the norm, it should default to a custom port instead. This fixes that issue and automatically sets the defaultZone, which was also missing.
@krickert
Copy link
Contributor Author

Bump - I had to add some more logic on my local one to property see the DefaultZone for the health checks. I have it working on my other branch, I'll soon push an update to it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant