Rebuild initial ctx when first test method has props #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
BrentDouglasB1
changed the title
Otherwise we want to keep the original context as other extensions or tests may expect to have the original context. This doesn't fix the issue where these two features don't play well together, but it drastically reduces the scope where they conflict. This means that we should be able to access the same context over the test lifecycle unless we are using property annotations on the test method.
BrentDouglasB1
force-pushed
the
1218_test-rebuild
branch
from
421e8a8 to
9ad8092
Compare
sdelamo
added
the
status: under consideration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we want to keep the original context as other extensions or tests may expect to have the original context. This doesn't fix the issue where these two features don't play well together, but it drastically reduces the scope where they conflict. This means that we should be able to access the same context over the test lifecycle unless we are using property annotations on the test method.