-
Notifications
You must be signed in to change notification settings - Fork 32
Add Oracle UCP telemetry #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.2.x
Are you sure you want to change the base?
Conversation
|
Does it make sense to also implement or |
|
What needs to be done to fix the build error? |
|
There are checkstyle errors |
Makes sense, I think |
|
Can test be added, maybe similar to JdbcTelemetrySpanSpec |
.../java/io/micronaut/tracing/opentelemetry/instrument/ucp/OracleUcpTelemetryConfiguration.java
Show resolved
Hide resolved
|
docs is missing from the |
|
Thanks for the reviews. I've done the following changes:
Regarding an extended test case I'm not sure how to implement it without a running Oracle Database. Or should I try to use the Testcontainers Oracle-XE Module? |
.../java/io/micronaut/tracing/opentelemetry/instrument/ucp/OracleUcpTelemetryConfiguration.java
Show resolved
Hide resolved
This commit adds a new module to integrate with the OpenTelemetry Library Instrumentation for Oracle UCP.
|
That is UCP, does not need to be Oracle connection. You can test it with H2 I guess. |
This commit adds a new module to integrate with the OpenTelemetry Library Instrumentation for Oracle UCP.