lora: Multiple small fixes (including syncword, sx126x minimum config) #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projectgus
force-pushed
the
bugfix/lora_sx126x
branch
2 times, most recently
from
45478af to
7a354cd
Compare
|
Build failure looks to be an unrelated regression from micropython/micropython#13620 |
projectgus
changed the title
projectgus
force-pushed
the
bugfix/lora_sx126x
branch
from
7a354cd to
a45c316
Compare
|
@oeysteinhansen If you have the opportunity, then it's possible to install the packages from this PR and verify the fix by running |
According to the docs, only freq_khz was needed for working output. However: - Without output_power setting, no output from SX1262 antenna (theory: output routed to the SX1261 antenna). - SF,BW,etc. settings were different from the SX127x power on defaults, so modems with an identical configuration were unable to communicate. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <[email protected]>
If send completes before the first call to poll_send(), the driver could get stuck in _sync_wait(). This had much less impact before rp2 port went tickless, as _sync_wait(will_irq=True) calls machine.idle() which may not wake very frequently on a tickless port. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <[email protected]>
This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <[email protected]>
Fixes issue micropython#796. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <[email protected]>
Changes are cosmetic - and maybe very minor code size - but not functional. _reg_read() was calling struct.packinto() with an incorrect number of arguments but it seems like MicroPython didn't mind, as result is correct for both versions. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <[email protected]>
dpgeorge
force-pushed
the
bugfix/lora_sx126x
branch
from
a45c316 to
2242465
Compare
|
Thanks, merged with relevant |
|
@dpgeorge Oops, good catch - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection of small LoRa fixes in individual commits. See commit messages for more details.
lora_cfgdidn't produce the documented results, some configuration keys always needed to be set.Test on SX1276, SX1262, STM32WL55.