Merge branch 'main' of https://github.com/microsoft/ALAppExtensions i…

…nto feature/LocalFileAccess
microsoft · Jan 17, 2025 · 592c862 · 592c862
2 parents fc24c3f + 821f23d
commit 592c862
Show file tree

Hide file tree

Showing 636 changed files with 793,464 additions and 16,548 deletions.
diff --git a/.github/AL-Go-Settings.json b/.github/AL-Go-Settings.json
@@ -5,7 +5,7 @@
   "runs-on": "windows-latest",
   "cacheImageName": "",
   "UsePsSession": false,
-  "artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/26.0.28000.0/base",
+  "artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/26.0.29027.0/base",
   "country": "base",
   "useProjectDependencies": true,
   "repoVersion": "26.0",

diff --git a/...tosoCoffeeDemoDatasetAT/app/Demo Data/Finance/1. Setup Data/CreateATGLAccount.Codeunit.al b/...tosoCoffeeDemoDatasetAT/app/Demo Data/Finance/1. Setup Data/CreateATGLAccount.Codeunit.al
@@ -1301,6 +1301,24 @@ codeunit 11148 "Create AT GL Account"
             until GLAccountCategory.Next() = 0;
     end;
 
+    internal procedure UpdateVATProdPostGrpInGLAccounts()
+    var
+        GLAccounts: Record "G/L Account";
+        CreateVATPostingGroups: Codeunit "Create VAT Posting Groups";
+        CreateVATPostingGroupAT: Codeunit "Create VAT Posting Group AT";
+    begin
+        GLAccounts.SetFilter("VAT Prod. Posting Group", '<>%1', '');
+        if GLAccounts.FindSet() then
+            repeat
+                if GLAccounts."VAT Prod. Posting Group" = CreateVATPostingGroups.Standard() then
+                    GLAccounts.Validate(GLAccounts."VAT Prod. Posting Group", CreateVATPostingGroupAT.VAT20());
+                if GLAccounts."VAT Prod. Posting Group" = CreateVATPostingGroups.Reduced() then
+                    GLAccounts.Validate(GLAccounts."VAT Prod. Posting Group", CreateVATPostingGroupAT.VAT10());
+                if GLAccounts."VAT Prod. Posting Group" <> CreateVATPostingGroupAT.NOVAT() then
+                    GLAccounts.Modify(true);
+            until GLAccounts.Next() = 0;
+    end;
+
     procedure AssignCategoryToChartOfAccounts(GLAccountCategory: Record "G/L Account Category")
     var
         CreateGLAccount: Codeunit "Create G/L Account";
@@ -1336,20 +1354,12 @@ codeunit 11148 "Create AT GL Account"
         CreateGLAccount: Codeunit "Create G/L Account";
     begin
         case GLAccountCategory.Description of
-            // GLAccountCategoryMgt.GetCurrentAssets():
-            //     ;
             GLAccountCategoryMgt.GetCash():
                 UpdateGLAccounts(GLAccountCategory, CashAndBank(), TotalCashAndBank());
             GLAccountCategoryMgt.GetAR():
                 UpdateGLAccounts(GLAccountCategory, OtherCurrentAssets(), TotalAccountsReceivable());
-            // GLAccountCategoryMgt.GetPrepaidExpenses():
-            //     ;
             GLAccountCategoryMgt.GetInventory():
                 UpdateGLAccounts(GLAccountCategory, SUPPLIES(), TOTALSUPPLIES());
-            // GLAccountCategoryMgt.GetEquipment():
-            //     ;
-            // GLAccountCategoryMgt.GetAccumDeprec():
-            //     ;
             GLAccountCategoryMgt.GetCurrentLiabilities():
                 begin
                     UpdateGLAccounts(GLAccountCategory, LIABILITIESPROVISIONS(), TotalProvisions());
@@ -1374,30 +1384,14 @@ codeunit 11148 "Create AT GL Account"
                 UpdateGLAccounts(GLAccountCategory, SalesRevenuesRawMaterial(), TotalSalesRevenuesRawMaterial());
             GLAccountCategoryMgt.GetIncomeSalesDiscounts():
                 UpdateGLAccounts(GLAccountCategory, RevenueAdjustments(), TotalRevenueAdjustments());
-            // GLAccountCategoryMgt.GetIncomeSalesReturns():
-            //     ;
             GLAccountCategoryMgt.GetIncomeInterest():
                 UpdateGLAccounts(GLAccountCategory, ChargesAndInterest(), TotalChargesAndInterest());
-            // GLAccountCategoryMgt.GetCOGSLabor():
-            //     ;
             GLAccountCategoryMgt.GetCOGSMaterials():
                 UpdateGLAccounts(GLAccountCategory, COSTOFMATERIALS(), TOTALCOSTOFMATERIALS());
-            // GLAccountCategoryMgt.GetRentExpense():
-            //     ;
-            // GLAccountCategoryMgt.GetAdvertisingExpense():
-            //     ;
             GLAccountCategoryMgt.GetInterestExpense():
                 UpdateGLAccounts(GLAccountCategory, FINANCIALREVENUESANDEXPENDITURESBeginTotal(), TotalFinancialIncomeAndExpensesEndTotal());
-            // GLAccountCategoryMgt.GetFeesExpense():
-            //     ;
-            // GLAccountCategoryMgt.GetInsuranceExpense():
-            //     ;
             GLAccountCategoryMgt.GetPayrollExpense():
                 UpdateGLAccounts(GLAccountCategory, CreateGLAccount.PersonnelExpenses(), CreateGLAccount.TotalPersonnelExpenses());
-            // GLAccountCategoryMgt.GetBenefitsExpense():
-            //     ;
-            // GLAccountCategoryMgt.GetRepairsExpense():
-            //     ;
             GLAccountCategoryMgt.GetUtilitiesExpense():
                 UpdateGLAccounts(GLAccountCategory, OfficeAdvertisingAndMaintenanceExpenditure(), TotalOfficeAdvertisingMaintenanceExpenditure());
             GLAccountCategoryMgt.GetOtherIncomeExpense():

diff --git a/...CoffeeDemoDatasetAT/app/Demo Data/Finance/1. Setup Data/CreatePostingGroupsAT.Codeunit.al b/...CoffeeDemoDatasetAT/app/Demo Data/Finance/1. Setup Data/CreatePostingGroupsAT.Codeunit.al
@@ -12,28 +12,12 @@ codeunit 11149 "Create Posting Groups AT"
     var
         ContosoPostingGroup: Codeunit "Contoso Posting Group";
         CreateVATPostingGroupAT: codeunit "Create VAT Posting Group AT";
-        CreatePostingGroup: Codeunit "Create Posting Groups";
     begin
         ContosoPostingGroup.SetOverwriteData(true);
         ContosoPostingGroup.InsertGenProductPostingGroup(NoVATPostingGroup(), MiscDescriptionLbl, CreateVATPostingGroupAT.NOVAT());
-        UpdateGenProdPostingGrp(CreatePostingGroup.FreightPostingGroup(), CreateVATPostingGroupAT.VAT20());
-        UpdateGenProdPostingGrp(CreatePostingGroup.RawMatPostingGroup(), CreateVATPostingGroupAT.VAT20());
-        UpdateGenProdPostingGrp(CreatePostingGroup.RetailPostingGroup(), CreateVATPostingGroupAT.VAT20());
-        UpdateGenProdPostingGrp(CreatePostingGroup.MiscPostingGroup(), CreateVATPostingGroupAT.VAT20());
-        UpdateGenProdPostingGrp(CreatePostingGroup.ServicesPostingGroup(), CreateVATPostingGroupAT.VAT10());
         ContosoPostingGroup.SetOverwriteData(false);
     end;
 
-    local procedure UpdateGenProdPostingGrp(ProdPostingGroup: COde[20]; DefaultVATProdPostingGroup: Code[20])
-    var
-        GenProdPostingGroup: Record "Gen. Product Posting Group";
-    begin
-        if GenProdPostingGroup.Get(ProdPostingGroup) then begin
-            GenProdPostingGroup.Validate("Def. VAT Prod. Posting Group", DefaultVATProdPostingGroup);
-            GenProdPostingGroup.Modify(true);
-        end;
-    end;
-
     procedure UpdateGenPostingSetup()
     var
         ContosoGenPostingSetup: Codeunit "Contoso Posting Setup";

diff --git a/...ffeeDemoDatasetAT/app/Demo Data/Finance/1. Setup Data/CreateVatPostingGroupAT.Codeunit.al b/...ffeeDemoDatasetAT/app/Demo Data/Finance/1. Setup Data/CreateVatPostingGroupAT.Codeunit.al
@@ -63,6 +63,27 @@ codeunit 11186 "Create VAT Posting Group AT"
         ContosoPostingGroup.InsertVATProductPostingGroup(VAT10(), StrSubstNo(MiscellaneousVATLbl, '10'));
     end;
 
+    procedure UpdateGeneralProdPostingGroup()
+    var
+        CreatePostingGroup: Codeunit "Create Posting Groups";
+    begin
+        UpdateGenProdPostingGrp(CreatePostingGroup.FreightPostingGroup(), VAT20());
+        UpdateGenProdPostingGrp(CreatePostingGroup.RawMatPostingGroup(), VAT20());
+        UpdateGenProdPostingGrp(CreatePostingGroup.RetailPostingGroup(), VAT20());
+        UpdateGenProdPostingGrp(CreatePostingGroup.MiscPostingGroup(), VAT20());
+        UpdateGenProdPostingGrp(CreatePostingGroup.ServicesPostingGroup(), VAT10());
+    end;
+
+    local procedure UpdateGenProdPostingGrp(ProdPostingGroup: COde[20]; DefaultVATProdPostingGroup: Code[20])
+    var
+        GenProdPostingGroup: Record "Gen. Product Posting Group";
+    begin
+        if GenProdPostingGroup.Get(ProdPostingGroup) then begin
+            GenProdPostingGroup.Validate("Def. VAT Prod. Posting Group", DefaultVATProdPostingGroup);
+            GenProdPostingGroup.Modify(true);
+        end;
+    end;
+
     procedure NOVAT(): Code[20]
     begin
         exit(NoVATTok);

diff --git a/...eeDemoDatasetAT/app/Demo Data/Finance/2. Master Data/CreateVatStatementNameAT.Codeunit.al b/...eeDemoDatasetAT/app/Demo Data/Finance/2. Master Data/CreateVatStatementNameAT.Codeunit.al
@@ -1,14 +1,14 @@
-codeunit 11189 "Create VAT Statement NameAT"
+codeunit 11189 "Create VAT Statement Name AT"
 {
     InherentEntitlements = X;
     InherentPermissions = X;
 
     trigger OnRun()
     var
         CreateVATStatement: Codeunit "Create VAT Statement";
-        ContosoVatStatmentES: Codeunit "Contoso Vat Statment ES";
+        ContosoVATStatement: Codeunit "Contoso VAT Statement";
     begin
-        ContosoVatStatmentES.InsertVATStatementName(CreateVATStatement.VATTemplateName(), StatementUstvaLbl, VATStatementGermanyDescLbl);
+        ContosoVATStatement.InsertVATStatementName(CreateVATStatement.VATTemplateName(), StatementUstvaLbl, VATStatementGermanyDescLbl);
     end;
 
     var

diff --git a/...soCoffeeDemoDatasetAT/app/Demo Data/Foundation/1. Setup Data/CreatePostCodeAT.Codeunit.al b/...soCoffeeDemoDatasetAT/app/Demo Data/Foundation/1. Setup Data/CreatePostCodeAT.Codeunit.al
@@ -3,14 +3,6 @@ codeunit 11145 "Create Post Code AT"
     InherentEntitlements = X;
     InherentPermissions = X;
 
-    // TODO: MS
-    // Discuss it
-    // Maybe a service provide a better list of post codes?
-    // This can be the same for now, then we convert to a list later.
-
-    // Keep as it is for now
-    // Wael
-
     trigger OnRun()
     var
         ContosoPostCodeDK: Codeunit "Contoso Post Code AT";

diff --git a/...ContosoCoffeeDemoDatasetAT/app/Demo Tool/Contoso Helpers/ContosoVatStatmentES.Codeunit.al b/...ContosoCoffeeDemoDatasetAT/app/Demo Tool/Contoso Helpers/ContosoVatStatmentES.Codeunit.al
diff --git a/Apps/AT/ContosoCoffeeDemoDatasetAT/app/Demo Tool/ContosoATLocalization.Codeunit.al b/Apps/AT/ContosoCoffeeDemoDatasetAT/app/Demo Tool/ContosoATLocalization.Codeunit.al
@@ -40,37 +40,41 @@ codeunit 11157 "Contoso AT Localization"
         case ContosoDemoDataLevel of
             Enum::"Contoso Demo Data Level"::"Setup Data":
                 begin
-                    Codeunit.Run(Codeunit::"Create Company Information AT");
                     Codeunit.Run(Codeunit::"Create No. Series AT");
                     Codeunit.Run(Codeunit::"Create Post Code AT");
                 end;
+            Enum::"Contoso Demo Data Level"::"Master Data":
+                Codeunit.Run(Codeunit::"Create Company Information AT");
         end;
     end;
 
     local procedure FinanceModule(ContosoDemoDataLevel: Enum "Contoso Demo Data Level")
     var
         CreateVatPostingGroupAT: Codeunit "Create VAT Posting Group AT";
         CreatePostingGroupsAT: Codeunit "Create Posting Groups AT";
+        CreateATGLAccount: Codeunit "Create AT GL Account";
     begin
         case ContosoDemoDataLevel of
             Enum::"Contoso Demo Data Level"::"Setup Data":
                 begin
                     Codeunit.Run(Codeunit::"Create AT GL Account");
                     CreateVatPostingGroupAT.CreateVATPostingSetup();
+                    CreateVatPostingGroupAT.UpdateGeneralProdPostingGroup();
+                    CreateATGLAccount.UpdateVATProdPostGrpInGLAccounts();
                     CreatePostingGroupsAT.UpdateGenPostingSetup();
                     Codeunit.Run(Codeunit::"Create Currency AT");
                     Codeunit.Run(Codeunit::"Create General Ledger Setup AT");
                     Codeunit.Run(Codeunit::"Create Vat Report Setup AT");
                     Codeunit.Run(Codeunit::"Create Vat Setup Post Grp AT");
+                    Codeunit.Run(Codeunit::"Create VAT Statement Name AT");
+                    Codeunit.Run(Codeunit::"Create VAT Statement Line AT");
                 end;
 
             Enum::"Contoso Demo Data Level"::"Master Data":
                 begin
                     Codeunit.Run(Codeunit::"Create Currency Ex. Rate AT");
                     Codeunit.Run(Codeunit::"Create Resource AT");
                     Codeunit.Run(Codeunit::"Create VAT Template AT");
-                    Codeunit.Run(Codeunit::"Create VAT Statement NameAT");
-                    Codeunit.Run(Codeunit::"Create VAT Statement Line AT");
                 end;
         end;
     end;
@@ -103,7 +107,7 @@ codeunit 11157 "Contoso AT Localization"
     end;
 
     [EventSubscriber(ObjectType::Codeunit, Codeunit::"Contoso Demo Tool", 'OnBeforeGeneratingDemoData', '', false, false)]
-    local procedure OnBeforeGeneratingDemoData(Module: Enum "Contoso Demo Data Module")
+    local procedure OnBeforeGeneratingDemoData(Module: Enum "Contoso Demo Data Module"; ContosoDemoDataLevel: Enum "Contoso Demo Data Level")
     var
         CreateResourceAT: Codeunit "Create Resource AT";
         CreateCurrencyExcRate: Codeunit "Create Currency Ex. Rate AT";
@@ -134,8 +138,10 @@ codeunit 11157 "Contoso AT Localization"
                 BindSubscription(CreatePaymentTermAT);
             Enum::"Contoso Demo Data Module"::Finance:
                 begin
-                    Codeunit.Run(Codeunit::"Create VAT Posting Group AT");
-                    Codeunit.Run(Codeunit::"Create Posting Groups AT");
+                    if ContosoDemoDataLevel = Enum::"Contoso Demo Data Level"::"Setup Data" then begin
+                        Codeunit.Run(Codeunit::"Create VAT Posting Group AT");
+                        Codeunit.Run(Codeunit::"Create Posting Groups AT");
+                    end;
                     BindSubscription(CreateResourceAT);
                     BindSubscription(CreateCurrencyExcRate);
                     BindSubscription(CreateAccScheduleLineAT);

diff --git a/...CoffeeDemoDatasetAU/app/DemoData/Finance/1.Setup Data/CreateAUAccScheduleLine.Codeunit.al b/...CoffeeDemoDatasetAU/app/DemoData/Finance/1.Setup Data/CreateAUAccScheduleLine.Codeunit.al
@@ -5,8 +5,6 @@ codeunit 17156 "Create AU Acc. Schedule Line"
     InherentEntitlements = X;
     InherentPermissions = X;
 
-    // ToDo: Need to Check with MS Team why standard Schedule Name are commented in W1
-
     [EventSubscriber(ObjectType::Table, Database::"Acc. Schedule Line", 'OnBeforeInsertEvent', '', false, false)]
     local procedure OnInsertRecord(var Rec: Record "Acc. Schedule Line")
     var

diff --git a/...CoffeeDemoDatasetAU/app/DemoData/Finance/1.Setup Data/CreateAUAccScheduleName.Codeunit.al b/...CoffeeDemoDatasetAU/app/DemoData/Finance/1.Setup Data/CreateAUAccScheduleName.Codeunit.al