Skip to content

Commit

Permalink
update changelog. version and fix linting
Browse files Browse the repository at this point in the history
  • Loading branch information
marrobi committed Feb 29, 2024
1 parent f42dac9 commit 0a9877f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ BUG FIXES:
* Airlock: Creating an import/export request causes a routing error ([#3830](https://github.com/microsoft/AzureTRE/issues/3830))
* Fix registration of templates with no 'authorizedRoles' or 'required' defined ([#3849](https://github.com/microsoft/AzureTRE/pull/3849))
* Update terraform for services bus to move network rules into namespace resource to avoid depreciation warning, and update setup_local_debugging.sh to use network_rule_sets ([#3858](https://github.com/microsoft/AzureTRE/pull/3858))
* Add workaround to avoid name clashes for storage accounts([#3863](https://github.com/microsoft/AzureTRE/pull/3858))

COMPONENTS:

Expand Down
2 changes: 1 addition & 1 deletion api_app/_version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.18.4"
__version__ = "0.18.5"
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ async def test_create_workspace_item_creates_a_workspace_with_the_right_values(m
workspace_to_create.properties.pop("address_spaces", None)
workspace_to_create.properties.pop("workspace_owner_object_id", None)


mock_is_workspace_storage_account_available.return_value = AsyncMock().return_value
mock_is_workspace_storage_account_available.return_value.return_value = False
validate_input_mock.return_value = basic_resource_template
Expand Down Expand Up @@ -309,7 +308,7 @@ async def test_is_worksapce_storage_account_available_when_name_available(mock_s
result = await workspace_repo.is_workspace_with_last_4_id(workspace_id)

mock_storage_client.return_value.storage_accounts.check_name_availability.assert_called_once_with({"name": f"stgws{workspace_id[-4:]}"})
assert result == False
assert result is False


@patch('azure.mgmt.storage.StorageManagementClient')
Expand All @@ -322,4 +321,4 @@ async def test_is_worksapce_storage_account_available_when_name_not_available(mo
result = await workspace_repo.is_workspace_with_last_4_id(workspace_id)

mock_storage_client.return_value.storage_accounts.check_name_availability.assert_called_once_with({"name": f"stgws{workspace_id[-4:]}"})
assert result == True
assert result is True

0 comments on commit 0a9877f

Please sign in to comment.