Address PR comments.

microsoft · Feb 17, 2025 · 5f8f953 · 5f8f953
1 parent ae3ad49
commit 5f8f953
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...s/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/terraform/locals.tf b/...s/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/terraform/locals.tf
@@ -8,7 +8,7 @@ locals {
   keyvault_name                  = lower("kv-${substr(local.workspace_resource_name_suffix, -20, -1)}")
   storage_name                   = lower(replace("stg${substr(local.workspace_resource_name_suffix, -8, -1)}", "-", ""))
   admin_username = (
-    length(data.azuread_user.user.mail) > 0 ?
+    ((length(data.azuread_user.user.mail) > 0) && (contains(data.azuread_user.user.user_principal_name, "#EXT#"))) ?
     substr(element(split("@", data.azuread_user.user.mail), 0), 0, 20) :
     substr(
       contains(element(split("@", data.azuread_user.user.user_principal_name), 0), "#EXT#") ?

diff --git a/...workspace_services/guacamole/user_resources/guacamole-azure-windowsvm/terraform/locals.tf b/...workspace_services/guacamole/user_resources/guacamole-azure-windowsvm/terraform/locals.tf
@@ -8,7 +8,7 @@ locals {
   keyvault_name                  = lower("kv-${substr(local.workspace_resource_name_suffix, -20, -1)}")
   storage_name                   = lower(replace("stg${substr(local.workspace_resource_name_suffix, -8, -1)}", "-", ""))
   admin_username = (
-    length(data.azuread_user.user.mail) > 0 ?
+    ((length(data.azuread_user.user.mail) > 0) && (contains(data.azuread_user.user.user_principal_name, "#EXT#"))) ?
     substr(element(split("@", data.azuread_user.user.mail), 0), 0, 20) :
     substr(
       contains(element(split("@", data.azuread_user.user.user_principal_name), 0), "#EXT#") ?