Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helps with preventing timeouts on ACR login of first job running first… #3853

Closed
wants to merge 5 commits into from
Closed

helps with preventing timeouts on ACR login of first job running first… #3853

wants to merge 5 commits into from

Conversation

nasaldrops
Copy link
Contributor

@nasaldrops nasaldrops commented Feb 20, 2024

Resolves timeouts issue when doing ACR login on its first job running first time.

Fixes #3778

@github-actions github-actions bot added the external PR from an external contributor label Feb 20, 2024
Copy link

github-actions bot commented Feb 20, 2024

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit a499b06.

♻️ This comment has been updated with latest results.

@marrobi
Copy link
Member

marrobi commented Feb 20, 2024

@nasaldrops thanks. Can you confirm this is to resolve this issue - #3778?

@nasaldrops
Copy link
Contributor Author

@nasaldrops thanks. Can you confirm this is to resolve this issue - #3778?

Can confirm it addresses 3778

@nasaldrops
Copy link
Contributor Author

@marrobi is this resolved now and can be closed?

@marrobi
Copy link
Member

marrobi commented Feb 22, 2024

@nasaldrops the PR neds to be reviewed and tested. We have an issue with our pipelines which is holding things up, you might see on your other PR we've been trying to work through things. Hopefully we will get to it in the next few days. Thanks.

@marrobi
Copy link
Member

marrobi commented Feb 27, 2024

@nasaldrops thanks for the PR, looks like some linting issues, any chance you can take a look and we can get this merged. Thanks.

@marrobi
Copy link
Member

marrobi commented Feb 28, 2024

Closing in preference of #3861

@marrobi marrobi closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external PR from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Action Deploy TRE fails on first run at ACR login step
3 participants