Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snyk Dockerfile python upgrades #3877

Closed
wants to merge 3 commits into from
Closed

snyk Dockerfile python upgrades #3877

wants to merge 3 commits into from

Conversation

nasaldrops
Copy link
Contributor

Resolves HASH_SIGN_FOLLOWED_BY_ISSUE_NUMBER

What is being addressed

Describe the current behavior you are modifying. Please also remember to update any impacted documentation.

How is this addressed

  • Describe the changes made, and if appropriate, why they are addressed this way
  • Note any pending work (with links to the issues that will address them)
  • Update documentation
  • Update CHANGELOG.md if needed
  • Increment template version if needed, for guidelines see Authoring templates - versioning

Copy link

github-actions bot commented Mar 18, 2024

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 2e71f6f.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll put a few general comments here:

  1. I think you should split the core application base image from the changes in the templates to 2 different PRs.
  2. Are you sure a jump (in the apps) from python 3.8 to 3.13 doesn't require code changes? Why are you upgrading to a RC version of python - it should be a GA one.
  3. You didn't upgrade the airlock function, why?
  4. In the apps, I think you should increase the minor version and not just the build number.
  5. We usually keep the same Debian version used across the entire solution - devcontainer, core apps and templates. You didn't include a devcontainer change which I think must be synced with the apps to enable good developer experience.

@tamirkamara tamirkamara deleted the python-upgrade branch February 5, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants