Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register TRE bundle workflow #4171

Closed
wants to merge 67 commits into from
Closed

Conversation

guybartal
Copy link
Collaborator

@guybartal guybartal commented Dec 9, 2024

What is being addressed

This workflow allows TRE Admins to publish and register a specific TRE bundle.

main changes

  1. Adding a new Register TRE Bundle workflow with the following inputs:
  • Bundle type (workspace, workspace-service, shared-service or user resource
  • Bundle name
  • Workspace service to register a user resource inside (required only if bundle-type == user-resource)
  1. Support for multiple command lines inside devcontainer action for readability and maintainability.

Copy link

github-actions bot commented Dec 9, 2024

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4f3c89f.

♻️ This comment has been updated with latest results.

@marrobi
Copy link
Member

marrobi commented Dec 9, 2024

@guybartal would this be better in the AzureTRE-Deployment repository?

Copy link
Collaborator

@tim-p-allen tim-p-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also change it to "Register Bundle" as that's the command its doing

@tim-p-allen
Copy link
Collaborator

tim-p-allen commented Dec 9, 2024

I think it should probably run a publish before it runs a register too

@tim-p-allen
Copy link
Collaborator

@guybartal would this be better in the AzureTRE-Deployment repository?

agree with @marrobi

@guybartal
Copy link
Collaborator Author

@guybartal would this be better in the AzureTRE-Deployment repository?

agree with @marrobi

@tamirkamara WDYT?

@marrobi
Copy link
Member

marrobi commented Dec 9, 2024

@guybartal would this be better in the AzureTRE-Deployment repository?

agree with @marrobi

@tamirkamara WDYT?

So my reasoning for having it in the deployment repo is:

  1. It's unlikely to be run in this repo.
  2. Avoids making PRs in this repo, and then having to wait for a release to update the other repo, when an just do it direct in the deployment repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants