Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable VS Code Extension Gallery to be proxied via Sonatype Nexus RM #4188

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Enable VS Code Extension Gallery to be proxied via Sonatype Nexus RM #4188

merged 5 commits into from
Dec 16, 2024

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Dec 11, 2024 •
edited
Loading

Fixes #4187

Add support for proxying VS Code Extension Gallery via Sonatype Nexus TM.

  • Documentation: Update docs/tre-templates/shared-services/nexus.md to include instructions for configuring and using the VS Code extensions proxy.
  • Configuration Script: Modify templates/shared_services/sonatype-nexus-vm/scripts/configure_nexus_repos.sh to add a new section for handling the VS Code extensions configuration.
  • Configuration File: Add templates/shared_services/sonatype-nexus-vm/scripts/nexus_repos_config/vscode_extensions_proxy_conf.json with appropriate settings for proxying VS Code extensions.

For more details, open the Copilot Workspace session.

@marrobi
Enable VS Code Extension Gallery to be proxied via Sonatype Nexus TM
2887a4d 
Fixes #4187

Add support for proxying VS Code Extension Gallery via Sonatype Nexus TM.

* **Documentation**: Update `docs/tre-templates/shared-services/nexus.md` to include instructions for configuring and using the VS Code extensions proxy.
* **Configuration Script**: Modify `templates/shared_services/sonatype-nexus-vm/scripts/configure_nexus_repos.sh` to add a new section for handling the VS Code extensions configuration.
* **Configuration File**: Add `templates/shared_services/sonatype-nexus-vm/scripts/nexus_repos_config/vscode_extensions_proxy_conf.json` with appropriate settings for proxying VS Code extensions.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4187?shareId=XXXX-XXXX-XXXX-XXXX).
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 3dce1c9.

♻️ This comment has been updated with latest results.

tim-p-allen
tim-p-allen approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@tim-p-allen tim-p-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrobi marrobi changed the title Enable VS Code Extension Gallery to be proxied via Sonatype Nexus TM Enable VS Code Extension Gallery to be proxied via Sonatype Nexus RM Dec 12, 2024
@marrobi marrobi requested a review from jonnyry December 12, 2024 12:07
@marrobi
Copy link
Member Author

marrobi commented Dec 12, 2024

/test-force-approve

Not tested.

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit e748651)

(in response to this comment from @marrobi)

@marrobi marrobi requested a review from tamirkamara December 12, 2024 12:07
@marrobi marrobi enabled auto-merge (squash) December 12, 2024 12:08
@marrobi marrobi requested a review from LizaShak December 16, 2024 11:51
LizaShak
LizaShak approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@LizaShak LizaShak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrobi
Copy link
Member Author

marrobi commented Dec 16, 2024

/test-force-appove - not tested

@marrobi
Copy link
Member Author

marrobi commented Dec 16, 2024

/test-force-approve

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

/test-force-appove is not recognised as a valid command.

You can use the following commands:
    /test - build, deploy and run smoke tests on a PR
    /test-extended - build, deploy and run smoke & extended tests on a PR
    /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR
    /test-shared-services - test the deployment of shared services on a PR build
    /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)
    /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)
    /help - show this help

(in response to this comment from @marrobi)

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 3dce1c9)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 397ab13 into main Dec 16, 2024
12 checks passed
@marrobi marrobi deleted the marrobi/add-vscode-extensions-proxy branch December 16, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LizaShak LizaShak LizaShak approved these changes

@tim-p-allen tim-p-allen tim-p-allen approved these changes

@jonnyry jonnyry Awaiting requested review from jonnyry

@tamirkamara tamirkamara Awaiting requested review from tamirkamara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable VS Code Extension Gallery to be proxied via Sonatype Nexus RM
3 participants
@marrobi @LizaShak @tim-p-allen