support multiple lines in devcontainer action #4192
Conversation
- Updated the action to create a temporary script file for the command execution, ensuring the script name is in lowercase. - Changed the command execution from directly passing the command to using the generated script file. - Cleaned up the temporary script file after execution. - Updated workflow files to use a multiline string for the COMMAND input, improving readability. This change enhances the handling of commands in the DevContainer action and maintains a cleaner environment post-execution.
guybartal
requested review from
Copilot,
tamirkamara and
marrobi
and removed request for
Copilot
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit eb2f907. ♻️ This comment has been updated with latest results. |
|
@guy has this been tested end to end? If so can you post a link to the run? Thanks. |
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12355453987 (with refid (in response to this comment from @guybartal) |
|
/help |
|
🤖 pr-bot 🤖 Hello! You can use the following commands: (in response to this comment from @guybartal) |
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13237061793 (with refid (in response to this comment from @guybartal) |
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13244500891 (with refid (in response to this comment from @guybartal) |
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13303567812 (with refid (in response to this comment from @guybartal) |
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit e53e247) (in response to this comment from @guybartal) |
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit eb2f907) (in response to this comment from @guybartal) |
Support multiple lines in devcontainer action
Before this PR CI workflow developers could only code commands in a single line (inline) to run inside devcontainer,
this becomes challenging to code complex scenarios and maintain it overtime as it is less readable.
This PR introduces a way to embed multiple shell command lines which are more readable and maintainable,
this inline script then materializes into a temp unique shell file which is mounted as
command.shfile inside the workspace path.