Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unix soft links support in shared filesystem #4193

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Dec 12, 2024

Fixes #4180

Enable Unix soft links support in shared filesystem for Unix VMs.

  • Autofs Configuration
    • Add uid=1000,gid=1000,mfsymlinks to the echo statement in templates/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/terraform/vm_config.sh to support Unix soft links and set proper ownership and permissions.

For more details, open the Copilot Workspace session.

Fixes #4180

Enable Unix soft links support in shared filesystem for Unix VMs.

* **Autofs Configuration**
  - Add `uid=1000,gid=1000,mfsymlinks` to the `echo` statement in `templates/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/terraform/vm_config.sh` to support Unix soft links and set proper ownership and permissions.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4180?shareId=XXXX-XXXX-XXXX-XXXX).
Copy link

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 8af2073.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • templates/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/terraform/vm_config.sh: Language not supported
@marrobi
Copy link
Member Author

marrobi commented Dec 12, 2024

/test-force-approve

Not tested.

Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 8af2073)

(in response to this comment from @marrobi)

Copy link
Collaborator

@tim-p-allen tim-p-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but haven't tested

@marrobi marrobi merged commit fbc4b55 into main Dec 13, 2024
13 checks passed
@marrobi marrobi deleted the marrobi/fix-unix-soft-links branch December 13, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared filesystem doesn't support Unix soft links
3 participants