Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable scheduled shutdown of Guacamole Linux VM #4196

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Enable scheduled shutdown of Guacamole Linux VM #4196

merged 6 commits into from
Dec 18, 2024

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Dec 13, 2024 •
edited
Loading

Add functionality to allow users to specify a daily shutdown time for Guacamole VMs, reducing costs. Update the UI to include options for enabling the shutdown schedule, setting the shutdown time, and selecting the timezone. Modify the necessary Terraform resources to implement this feature.

image

Will create separate issue for Windows VMs once merged.

Fixes #4186

@marrobi marrobi changed the title Enable scheduled shutdown of Guacamole VMs Enable scheduled shutdown of Guacamole Linux VM Dec 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit b4a2396.

♻️ This comment has been updated with latest results.

@tim-p-allen
Copy link
Collaborator

does the TRE recognise the machine is stopped and display a Start button in the menu?

@marrobi
Copy link
Member Author

marrobi commented Dec 16, 2024 •
edited
Loading

does the TRE recognise the machine is stopped and display a Start button in the menu?

The page might need a refresh, not sure if any way around that, unless use the webhook somehow. Actually the UI would need to poll. I'll check and we can take that as a separate issue.

@marrobi marrobi requested a review from tim-p-allen December 17, 2024 11:00
tim-p-allen
tim-p-allen approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@tim-p-allen tim-p-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to raise a separate issue for polling.

@marrobi
Copy link
Member Author

marrobi commented Dec 17, 2024

LGTM, happy to raise a separate issue for polling.

@tim-allen-ck please, can you raise the equivalent of this and scheduled for
Windows too.

@marrobi
Copy link
Member Author

marrobi commented Dec 17, 2024

/test-force-approve

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit bca1bed)

(in response to this comment from @marrobi)

@tim-p-allen tim-p-allen mentioned this pull request Dec 17, 2024
Open
@marrobi marrobi enabled auto-merge (squash) December 18, 2024 09:17
@tim-p-allen
Copy link
Collaborator

/test-force-approve

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit b4a2396)

(in response to this comment from @tim-allen-ck)

@marrobi marrobi merged commit a7c9a28 into microsoft:main Dec 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirkamara tamirkamara tamirkamara approved these changes

@tim-p-allen tim-p-allen tim-p-allen approved these changes

@jonnyry jonnyry Awaiting requested review from jonnyry

@LizaShak LizaShak Awaiting requested review from LizaShak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Scheduled Shutdown of Guacamole Linux VMs
3 participants
@marrobi @tim-p-allen @tamirkamara