Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace storage account SKU choice (GRS, ZRS) #4226

Merged
merged 8 commits into from
Dec 31, 2024
Merged

Conversation

ShakutaiGit
Copy link
Collaborator

Resolves #4223

What is being addressed

This pull request introduces several changes to the templates/workspaces/base directory to add support for configurable storage account redundancy in Azure TRE workspaces (ZRS / GRS). The changes span multiple files including porter.yaml, template_schema.json, and Terraform configuration files.

Key Changes:

Configuration Updates:

  • templates/workspaces/base/porter.yaml: Added a new parameter storage_account_redundancy to specify the redundancy option for the storage account, with a default value of "GRS" (Geo-Redundant Storage). This parameter is included in both the install and upgrade sections. [1] [2] [3]

Schema Updates:

Terraform Configuration:

Version Update:

Copy link

github-actions bot commented Dec 29, 2024

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 0110ba6.

♻️ This comment has been updated with latest results.

@ShakutaiGit ShakutaiGit changed the title Add storage account redundancy parameter and update related configura… Workspace storage account SKU choice (GRS, ZRS) Dec 29, 2024
Copy link
Collaborator

@yuvalyaron yuvalyaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than Tamir's comments

@tamirkamara
Copy link
Collaborator

/test-extended

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12536369306 (with refid 3e2ef676)

(in response to this comment from @tamirkamara)

@ShakutaiGit ShakutaiGit enabled auto-merge (squash) December 29, 2024 15:06
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12536369306 (with refid 3e2ef676)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator

/test-extended

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12537683825 (with refid 3e2ef676)

(in response to this comment from @tamirkamara)

1 similar comment
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12537683825 (with refid 3e2ef676)

(in response to this comment from @tamirkamara)

@ShakutaiGit
Copy link
Collaborator Author

/test-extended

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12547467791 (with refid 3e2ef676)

(in response to this comment from @ShakutaiGit)

@ShakutaiGit
Copy link
Collaborator Author

/test-extended

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12550271074 (with refid 3e2ef676)

(in response to this comment from @ShakutaiGit)

@ShakutaiGit
Copy link
Collaborator Author

/test-extended

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12552389720 (with refid 3e2ef676)

(in response to this comment from @ShakutaiGit)

@ShakutaiGit ShakutaiGit merged commit 205f10b into main Dec 31, 2024
12 checks passed
@ShakutaiGit ShakutaiGit deleted the sku_decision_4223 branch December 31, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace storage account SKU choice
4 participants