-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace storage account SKU choice (GRS, ZRS) #4226
Conversation
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 0110ba6. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than Tamir's comments
…rameter & lint issue.
…eTRE into sku_decision_4223
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12536369306 (with refid (in response to this comment from @tamirkamara) |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12536369306 (with refid (in response to this comment from @tamirkamara) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12537683825 (with refid (in response to this comment from @tamirkamara) |
1 similar comment
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12537683825 (with refid (in response to this comment from @tamirkamara) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12547467791 (with refid (in response to this comment from @ShakutaiGit) |
…_decision_4223
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12550271074 (with refid (in response to this comment from @ShakutaiGit) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12552389720 (with refid (in response to this comment from @ShakutaiGit) |
Resolves #4223
What is being addressed
This pull request introduces several changes to the
templates/workspaces/base
directory to add support for configurable storage account redundancy in Azure TRE workspaces (ZRS / GRS). The changes span multiple files includingporter.yaml
,template_schema.json
, and Terraform configuration files.Key Changes:
Configuration Updates:
templates/workspaces/base/porter.yaml
: Added a new parameterstorage_account_redundancy
to specify the redundancy option for the storage account, with a default value of "GRS" (Geo-Redundant Storage). This parameter is included in both theinstall
andupgrade
sections. [1] [2] [3]Schema Updates:
templates/workspaces/base/template_schema.json
: Added a new schema propertystorage_account_redundancy
with options "GRS" and "ZRS" (Zone-Redundant Storage) to validate the redundancy option for the storage account. [1] [2]Terraform Configuration:
templates/workspaces/base/terraform/storage.tf
: Updated theazurerm_storage_account
resource to use the newstorage_account_redundancy
variable for theaccount_replication_type
property.templates/workspaces/base/terraform/variables.tf
: Added a new variablestorage_account_redundancy
to define the redundancy option for the storage account in the Terraform configuration.Version Update:
templates/workspaces/base/porter.yaml
: Incremented the version from 1.8.1 to 1.8.2.