-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CMK options in workflows #4249
base: main
Are you sure you want to change the base?
Conversation
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 0975c9b. ♻️ This comment has been updated with latest results. |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12620906900 (with refid (in response to this comment from @tamirkamara) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12627794742 (with refid (in response to this comment from @tamirkamara) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12632163170 (with refid (in response to this comment from @tamirkamara) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 15 changed files in this pull request and generated 3 comments.
Files not reviewed (10)
- config_schema.json: Language not supported
- core/terraform/variables.tf: Language not supported
- core/version.txt: Language not supported
- devops/terraform/variables.tf: Language not supported
- devops/version.txt: Language not supported
- .github/workflows/pr_comment_bot.yml: Evaluated as low risk
- docs/tre-admins/environment-variables.md: Evaluated as low risk
- docs/tre-admins/setup-instructions/cicd-pre-deployment-steps.md: Evaluated as low risk
- .github/workflows/deploy_tre.yml: Evaluated as low risk
- .github/workflows/deploy_tre_branch.yml: Evaluated as low risk
Comments suppressed due to low confidence (1)
.github/actions/devcontainer_run_command/action.yml:141
- [nitpick] The description for 'ENCRYPTION_KV_NAME' is empty. It should be more descriptive, e.g., 'The name of the Key Vault for CMK encryption'.
description: ""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM albeit haven't tested, couple of comments/questions.
Has this been tested somewhere - the workflows with CMK enabled? Be good to see a successful run.
Co-authored-by: Copilot <[email protected]>
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12632841658 (with refid (in response to this comment from @tamirkamara) |
@yuvalyaron do you know what this is waiting for/why it is in draft? |
@marrobi not sure, perhaps it wasn't tested? |
We want to enable CMK via CI/CD, so will assign to yourself. |
…irkamara/4148-cmk-in-gh-actions
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13392638924 (with refid (in response to this comment from @yuvalyaron) |
Resolves #4148
What is being addressed
Adding support for CMK GH Actions workflows.
How is this addressed