Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable encryption at host for vms #4263

Merged
merged 7 commits into from
Jan 28, 2025

Conversation

yuvalyaron
Copy link
Collaborator

Added encryption at host for VMs

Copy link

github-actions bot commented Jan 8, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit e4294c0.

♻️ This comment has been updated with latest results.

@yuvalyaron yuvalyaron changed the title enable encryption at host for vms Enable encryption at host for vms Jan 8, 2025
@yuvalyaron yuvalyaron requested review from tamirkamara, jonnyry and marrobi and removed request for tamirkamara January 8, 2025 12:04
Copy link
Collaborator

@jonnyry jonnyry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuvalyaron just needs an addition to the CHANGELOG

@marrobi
Copy link
Member

marrobi commented Jan 23, 2025

@yuvalyaron can you do the changelog please?

@jonnyry
Copy link
Collaborator

jonnyry commented Jan 27, 2025

Hi @yuvalyaron could you increment the core version number? Thanks

@yuvalyaron
Copy link
Collaborator Author

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12999712181 (with refid 3435fcdd)

(in response to this comment from @yuvalyaron)

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrobi
Copy link
Member

marrobi commented Jan 28, 2025

/test-force-approve

Tested locally.

@marrobi marrobi enabled auto-merge (squash) January 28, 2025 16:50
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit e4294c0)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 7c88fe4 into microsoft:main Jan 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants