Surface the Guacamole server-layout parameter #4266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results15 tests 15 ✅ 1s ⏱️ Results for commit 190d5b3. ♻️ This comment has been updated with latest results. |
|
/test c7d9536 |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12727241175 (with refid (in response to this comment from @jonnyry) |
marrobi
approved these changes
Jan 12, 2025
|
/test-force-approve (Previously tested here #4266 (comment)) |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 190d5b3) (in response to this comment from @jonnyry) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4234
What is being addressed
Surfaces the Guacamole server-layout parameter within the Guacamole template.
This change doesn't expose the setting within the UI, since its unlikely to be changed on a per workspace basis, more likely when configuring custom images within user resource templates. This change makes it easier for TRE implementers to override the value in their downstream forks without having to dig deep within the guacamole-azure-auth code (particularly when using the --build-context template 'inheritance' mechanism).