Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airlock Azure Function Host Storage Access with Managed Identity #4276

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

The azure function that serves the airlock feature uses its host storage with a shared access key which is less secure.

How is this addressed

  • It took a while to find this undocumented way to direct the function to use the user-assigned managed identity it already has.

Copy link

github-actions bot commented Jan 19, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit a596f4c.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test-extended

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12851174798 (with refid b62c5abf)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara marked this pull request as ready for review January 19, 2025 06:39
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Took some time to start working.

@tamirkamara
Copy link
Collaborator Author

/test

Copy link

github-actions bot commented Feb 2, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13096406243 (with refid b62c5abf)

(in response to this comment from @tamirkamara)

2 similar comments
Copy link

github-actions bot commented Feb 2, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13096406243 (with refid b62c5abf)

(in response to this comment from @tamirkamara)

Copy link

github-actions bot commented Feb 2, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13096406243 (with refid b62c5abf)

(in response to this comment from @tamirkamara)

Copy link

github-actions bot commented Feb 2, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13096406243 (with refid b62c5abf)

(in response to this comment from @tamirkamara)

1 similar comment
Copy link

github-actions bot commented Feb 3, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13096406243 (with refid b62c5abf)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

Copy link

github-actions bot commented Feb 4, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13129532316 (with refid b62c5abf)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 26621d1 into main Feb 5, 2025
186 of 205 checks passed
@tamirkamara tamirkamara deleted the tamirkamara/function-host-storage-mi branch February 5, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants