Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade certs shared service App Gateway to Basic SKU #4301

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

jonnyry
Copy link
Collaborator

@jonnyry jonnyry commented Feb 3, 2025

Resolves #4300

Note: Tested locally (including deploying Nexus)

@jonnyry jonnyry requested a review from marrobi February 3, 2025 15:39
Copy link

github-actions bot commented Feb 3, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 8fe7247.

♻️ This comment has been updated with latest results.

@jonnyry jonnyry requested a review from tamirkamara February 3, 2025 15:39
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonnyry jonnyry changed the title Downgrade certs shared service App Gateway to Basic SKU #4300 Downgrade certs shared service App Gateway to Basic SKU Feb 3, 2025
@jonnyry
Copy link
Collaborator Author

jonnyry commented Feb 4, 2025

/test b3321e7

Copy link

github-actions bot commented Feb 4, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13141889133 (with refid 607b86de)

(in response to this comment from @jonnyry)

@jonnyry
Copy link
Collaborator Author

jonnyry commented Feb 4, 2025

/test b3321e7

Copy link

github-actions bot commented Feb 4, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13141968107 (with refid 607b86de)

(in response to this comment from @jonnyry)

@jonnyry jonnyry enabled auto-merge (squash) February 4, 2025 18:20
@jonnyry
Copy link
Collaborator Author

jonnyry commented Feb 5, 2025

/test-force-approve

Tested locally, CI doesn't covert certs service

Copy link

github-actions bot commented Feb 5, 2025

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 8fe7247)

(in response to this comment from @jonnyry)

@jonnyry jonnyry merged commit 3838df2 into microsoft:main Feb 5, 2025
12 checks passed
@jonnyry jonnyry deleted the jr/upstream-main/143-certs-appgw-sku branch February 5, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downgrade certs shared service App Gateway to Basic SKU
3 participants