Validation missing from template registration API endpoints #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add validation for `resourceType` property in template registration API endpoints. * **Helpers**: - Add `validate_resource_type` function in `api_app/api/helpers.py` to validate the `resourceType` property. - Add missing import for `ResourceType` in `api_app/api/helpers.py`. * **Workspace Templates**: - Use `validate_resource_type` in `register_workspace_template` function in `api_app/api/routes/workspace_templates.py`. - Add test cases in `api_app/tests_ma/test_api/test_routes/test_workspace_templates.py` to validate `resourceType` property in `register_workspace_template` function. * **Workspace Service Templates**: - Use `validate_resource_type` in `register_workspace_service_template` function in `api_app/api/routes/workspace_service_templates.py`. - Add test cases in `api_app/tests_ma/test_api/test_routes/test_workspace_service_templates.py` to validate `resourceType` property in `register_workspace_service_template` function. * **Shared Service Templates**: - Use `validate_resource_type` in `register_shared_service_template` function in `api_app/api/routes/shared_service_templates.py`. - Add test cases in `api_app/tests_ma/test_api/test_routes/test_shared_service_templates.py` to validate `resourceType` property in `register_shared_service_template` function.
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit d60e71f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation for
resourceTypeproperty in template registration API endpoints.Helpers:
validate_resource_typefunction inapi_app/api/helpers.pyto validate theresourceTypeproperty.ResourceTypeinapi_app/api/helpers.py.Workspace Templates:
validate_resource_typeinregister_workspace_templatefunction inapi_app/api/routes/workspace_templates.py.api_app/tests_ma/test_api/test_routes/test_workspace_templates.pyto validateresourceTypeproperty inregister_workspace_templatefunction.Workspace Service Templates:
validate_resource_typeinregister_workspace_service_templatefunction inapi_app/api/routes/workspace_service_templates.py.api_app/tests_ma/test_api/test_routes/test_workspace_service_templates.pyto validateresourceTypeproperty inregister_workspace_service_templatefunction.Shared Service Templates:
validate_resource_typeinregister_shared_service_templatefunction inapi_app/api/routes/shared_service_templates.py.api_app/tests_ma/test_api/test_routes/test_shared_service_templates.pyto validateresourceTypeproperty inregister_shared_service_templatefunction.