Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev container initialization on Windows #4327

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Feb 6, 2025

Fixes #4325

Add platform-specific initialization scripts for dev container.

  • Add initialize.sh script: Create directories .azure and .config in the user's home directory using Bash.
  • Add initialize.cmd script: Create directories .azure and .config in the user's profile directory using Windows command line.
  • Update initializeCommand in devcontainer.json: Use array syntax to reference the new platform-specific initialization scripts.

For more details, open the Copilot Workspace session.

Fixes #4325

Add platform-specific initialization scripts for dev container.

* **Add `initialize.sh` script**: Create directories `.azure` and `.config` in the user's home directory using Bash.
* **Add `initialize.cmd` script**: Create directories `.azure` and `.config` in the user's profile directory using Windows command line.
* **Update `initializeCommand` in `devcontainer.json`**: Use array syntax to reference the new platform-specific initialization scripts.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4325?shareId=XXXX-XXXX-XXXX-XXXX).
@marrobi
Copy link
Member Author

marrobi commented Feb 6, 2025

@jonnyry mind giving this a test? I'll test too.

Copy link

github-actions bot commented Feb 6, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 0aa8aec.

♻️ This comment has been updated with latest results.

@jonnyry
Copy link
Collaborator

jonnyry commented Feb 6, 2025

@jonnyry mind giving this a test? I'll test too.

It doesn't crash and allows you to load the container.

image

@marrobi
Copy link
Member Author

marrobi commented Feb 6, 2025

Verified works in WSL.

@marrobi
Copy link
Member Author

marrobi commented Feb 6, 2025

/test

@marrobi marrobi enabled auto-merge (squash) February 6, 2025 10:05
Copy link

github-actions bot commented Feb 6, 2025

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13176346096 (with refid 66a89be7)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Feb 6, 2025

/test-force-approve

Tests passed the point of container build.

@marrobi
Copy link
Member Author

marrobi commented Feb 6, 2025

/test-destroy-env

Copy link

github-actions bot commented Feb 6, 2025

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 0aa8aec)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 7ae3d18 into main Feb 6, 2025
12 checks passed
@marrobi marrobi deleted the marrobi/fix-dev-container branch February 6, 2025 10:32
Copy link

github-actions bot commented Feb 6, 2025

Destroying branch test environment (RG: rg-tredf4e9399)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13176834107)

Copy link

github-actions bot commented Feb 6, 2025

Branch test environment destroy complete (RG: rg-tredf4e9399)

Copy link

github-actions bot commented Feb 6, 2025

Destroying PR test environment (RG: rg-tre66a89be7)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13176834107)

Copy link

github-actions bot commented Feb 6, 2025

PR test environment destroy complete (RG: rg-tre66a89be7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev Container fails when launched from Windows
3 participants