-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dev container initialization on Windows #4327
Conversation
Fixes #4325 Add platform-specific initialization scripts for dev container. * **Add `initialize.sh` script**: Create directories `.azure` and `.config` in the user's home directory using Bash. * **Add `initialize.cmd` script**: Create directories `.azure` and `.config` in the user's profile directory using Windows command line. * **Update `initializeCommand` in `devcontainer.json`**: Use array syntax to reference the new platform-specific initialization scripts. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4325?shareId=XXXX-XXXX-XXXX-XXXX).
@jonnyry mind giving this a test? I'll test too. |
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 0aa8aec. ♻️ This comment has been updated with latest results. |
It doesn't crash and allows you to load the container. |
Verified works in WSL. |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13176346096 (with refid (in response to this comment from @marrobi) |
/test-force-approve Tests passed the point of container build. |
/test-destroy-env |
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 0aa8aec) (in response to this comment from @marrobi) |
Destroying branch test environment (RG: rg-tredf4e9399)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13176834107) |
Branch test environment destroy complete (RG: rg-tredf4e9399) |
Destroying PR test environment (RG: rg-tre66a89be7)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13176834107) |
PR test environment destroy complete (RG: rg-tre66a89be7) |
Fixes #4325
Add platform-specific initialization scripts for dev container.
initialize.sh
script: Create directories.azure
and.config
in the user's home directory using Bash.initialize.cmd
script: Create directories.azure
and.config
in the user's profile directory using Windows command line.initializeCommand
indevcontainer.json
: Use array syntax to reference the new platform-specific initialization scripts.For more details, open the Copilot Workspace session.