Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure Machine Learning workspace to use AD integrated auth to storage #4341

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Feb 7, 2025

Refactor the Azure Machine Learning workspace resource to use the azapi provider so don;t have to use key based storage auth.

@marrobi marrobi requested a review from Copilot February 7, 2025 20:41

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (7)
  • templates/workspace_services/azureml/terraform/.terraform.lock.hcl: Language not supported
  • templates/workspace_services/azureml/terraform/compute.tf: Language not supported
  • templates/workspace_services/azureml/terraform/main.tf: Language not supported
  • templates/workspace_services/azureml/terraform/network.tf: Language not supported
  • templates/workspace_services/azureml/terraform/outputs.tf: Language not supported
  • templates/workspace_services/azureml/terraform/providers.tf: Language not supported
  • templates/workspace_services/azureml/terraform/roles.tf: Language not supported
Copy link

github-actions bot commented Feb 7, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 8d0231d.

♻️ This comment has been updated with latest results.

@marrobi marrobi changed the title Update Azure Machine Learning workspace to use AD itegrated auth to storage Update Azure Machine Learning workspace to use AD integrated auth to storage Feb 17, 2025
@marrobi marrobi marked this pull request as ready for review February 19, 2025 12:22
@marrobi marrobi requested a review from Copilot February 19, 2025 12:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 9 changed files in this pull request and generated 1 comment.

Files not reviewed (7)
  • templates/workspace_services/azureml/terraform/.terraform.lock.hcl: Language not supported
  • templates/workspace_services/azureml/terraform/compute.tf: Language not supported
  • templates/workspace_services/azureml/terraform/main.tf: Language not supported
  • templates/workspace_services/azureml/terraform/network.tf: Language not supported
  • templates/workspace_services/azureml/terraform/outputs.tf: Language not supported
  • templates/workspace_services/azureml/terraform/providers.tf: Language not supported
  • templates/workspace_services/azureml/terraform/roles.tf: Language not supported

Co-authored-by: Copilot <[email protected]>
@marrobi marrobi requested review from jonnyry and LizaShak February 19, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants