Fix firewall rules creation on upgrade for Guacamole #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3814 Add firewall rule creation to the upgrade step in Guacamole template schema. * Add a step to the `upgrade` section in `templates/workspace_services/guacamole/template_schema.json` to add network firewall rules for Guacamole. * Ensure the new step in the `upgrade` section matches the step in the `install` section. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/3814?shareId=XXXX-XXXX-XXXX-XXXX).
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 4ad069e. ♻️ This comment has been updated with latest results. |
jonnyry
reviewed
Feb 17, 2025
jonnyry
approved these changes
Feb 17, 2025
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13389976976 (with refid (in response to this comment from @marrobi) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3814
Add firewall rule creation to the upgrade step in Guacamole template schema.
upgradesection intemplates/workspace_services/guacamole/template_schema.jsonto add network firewall rules for Guacamole.upgradesection matches the step in theinstallsection.For more details, open the Copilot Workspace session.