-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove public IP from TRE's firewall when forced tunneling is configured #4346
Remove public IP from TRE's firewall when forced tunneling is configured #4346
Conversation
…7-remove-public-ip-when-forced-tunneling
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 2d1c932. ♻️ This comment has been updated with latest results. |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13226992452 (with refid (in response to this comment from @yuvalyaron) |
/help |
🤖 pr-bot 🤖 Hello! You can use the following commands: (in response to this comment from @yuvalyaron) |
/test-destroy-env |
Destroying PR test environment (RG: rg-trec4c99fa9)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13227676379) |
PR test environment destroy complete (RG: rg-trec4c99fa9) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13228076922 (with refid (in response to this comment from @yuvalyaron) |
…7-remove-public-ip-when-forced-tunneling
/test-force-approve |
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 2d1c932) (in response to this comment from @yuvalyaron) |
@yuvalyaron getting:
When upgrading the firewall, I don't; have forced tunnelling enabled. Can you look at this as will block any users who take main. Thanks. |
Resolves #4237
What is being addressed
When forced tunneling is configured on TRE's firewall, its public IP is not in use, hence we should not deploy it.