Add requests endpoint to core TRE API #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new 'requests' endpoint in the core TRE API to view airlock requests across workspaces.
Unit Test Results608 tests 608 ✅ 6s ⏱️ Results for commit 20c5138. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Copilot reviewed 5 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (8)
- api_app/api/routes/api.py: Evaluated as low risk
- ui/app/src/components/root/RootLayout.tsx: Evaluated as low risk
- CHANGELOG.md: Evaluated as low risk
- api_app/api/dependencies/database.py: Evaluated as low risk
- api_app/resources/strings.py: Evaluated as low risk
- api_app/_version.py: Evaluated as low risk
- ui/app/src/components/shared/RequestsList.tsx: Evaluated as low risk
- ui/app/src/models/apiEndpoints.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
api_app/db/repositories/airlock_requests.py:135
- The parameter for workspace_id should only be included if workspace_id is provided. Add a conditional check to include this parameter only when workspace_id is not None.
{"name": "@workspace_id", "value": workspace_id},
… into marrobi/issue2510
There was a problem hiding this comment.
Copilot reviewed 5 out of 14 changed files in this pull request and generated no comments.
Files not reviewed (9)
- ui/app/package.json: Language not supported
- api_app/api/routes/api.py: Evaluated as low risk
- ui/app/src/components/root/RootLayout.tsx: Evaluated as low risk
- CHANGELOG.md: Evaluated as low risk
- api_app/api/dependencies/database.py: Evaluated as low risk
- api_app/_version.py: Evaluated as low risk
- api_app/resources/strings.py: Evaluated as low risk
- ui/app/src/models/apiEndpoints.ts: Evaluated as low risk
- api_app/db/repositories/airlock_requests.py: Evaluated as low risk
ShakutaiGit
approved these changes
Feb 12, 2025
ShakutaiGit
approved these changes
Feb 12, 2025
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13285817274 (with refid (in response to this comment from @marrobi) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new 'requests' endpoint in the core TRE API to facilitate viewing airlock requests across workspaces, along with corresponding tests for added functionality.
api/requests/takes airlock_manager bool to get requests for workspaces where the user is an airlock manager.Fixes #2510