Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moved block to handle firewall public IP count migration #4357

Merged

Conversation

yuvalyaron
Copy link
Collaborator

Resolves #4355

What is being addressed

Updated the moved block to handle resource address change when adding count to
the firewall's public IP resource, preventing unwanted recreation of the IP address.

the firewall's public IP resource, preventing unwanted recreation of the
IP address
@yuvalyaron
Copy link
Collaborator Author

/test

Copy link

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 7c34c98.

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13264086838 (with refid c6d4514c)

(in response to this comment from @yuvalyaron)

@yuvalyaron yuvalyaron changed the title Adds moved block to handle resource address change when adding count to Add moved block to handle firewall public IP count migration Feb 11, 2025
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuvalyaron yuvalyaron merged commit 0715eca into microsoft:main Feb 11, 2025
13 checks passed
@yuvalyaron yuvalyaron deleted the 4355-fw-public-ip-count-migration branch February 11, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firewall Upgrade: PublicIPAddressCannotBeDeleted
3 participants