Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backups to workspaces. ignore this. #4378

Conversation

james-annages
Copy link

Resolves #4362

This pull request introduces significant updates to the base template for workspaces, primarily focusing on adding backup capabilities and enhancing the cleanup process for Azure Recovery Services Vaults. The key changes include the addition of new parameters and outputs, updates to the porter.yaml file for handling backups, and the creation of new Terraform resources for managing backups.

Backup and Recovery Enhancements:

Parameter and Schema Updates:

Terraform Configuration:

Role Assignments:

These changes collectively enhance the robustness of the workspace by adding comprehensive backup and recovery functionalities, ensuring that critical data can be protected and restored as needed.

What is being addressed

Added in a boolen for enable_backup that is set in the workspace config window. The system will deploy a recovery vault and the needed policy's.
It passes the names of the polices back out so they can be used by other services (sql, vm, etc).

How is this addressed

  • Added terrafrom code to deploy the needed objects. Changed some of the settings for deploying shared vm storage.
  • still needs a management ui for recovery, ability to set the retention and backup policy. And possibly give the ability to move the backups to a diffrent storage account for archive.
  • Workspace documentation needs to be updated. NOT COMPLETED YET!
  • base workspace have been bumped up. This needs to be fixed as it was changed for my testing.

Adding Backup vault to the base workspace.
Allows enableing or disableing of the vault. Also added a step to purge the vault as apart of the clean up and removal.
removed the depends on to the airlock as that maynot be enabled.
@github-actions github-actions bot added the external PR from an external contributor label Feb 18, 2025
@james-annages james-annages changed the title Add backups to workspaces. Add backups to workspaces. ignore this. Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external PR from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Automated Backup Management for Shared VM Storage in Azure TRE
1 participant