-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bastion sku configuration #4383
base: main
Are you sure you want to change the base?
Conversation
Fixes #86 Add a variable to configure Azure Bastion SKU and default to Developer (free). * Add `bastion_sku` variable to `config.sample.yaml` with default value `Developer`. * Add conditional logic in `core/terraform/bastion.tf` to deploy Azure Bastion based on `bastion_sku` variable. * Update `azurerm_bastion_host` resource in `core/terraform/bastion.tf` to use `bastion_sku` variable. * Add `bastion_sku` variable to `core/terraform/variables.tf` with default value `Developer`. * Add `bastion_sku` variable to `config_schema.json`. * Document the new `bastion_sku` variable in `docs/tre-admins/environment-variables.md`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/86?shareId=XXXX-XXXX-XXXX-XXXX).
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit fe098ad. ♻️ This comment has been updated with latest results. |
* Update `config.sample.yaml` to include `bastion_sku` variable with default value `Developer` * Update `docs/tre-admins/environment-variables.md` to document the new `bastion_sku` variable and its allowed values
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13418035949 (with refid (in response to this comment from @marrobi) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13418661236 (with refid (in response to this comment from @marrobi) |
Switching to draft given limited region availability. |
/test-destroy-env |
Destroying branch test environment (RG: rg-tre99b35af5)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13421727493) |
Branch test environment destroy complete (RG: rg-tre99b35af5) |
Destroying PR test environment (RG: rg-treedf3a526)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13421727493) |
PR test environment destroy complete (RG: rg-treedf3a526) |
Fixes #86
Add a variable to configure Azure Bastion SKU and default to Developer (free).
bastion_sku
variable toconfig.sample.yaml
with default valueDeveloper
.core/terraform/bastion.tf
to deploy Azure Bastion based onbastion_sku
variable.azurerm_bastion_host
resource incore/terraform/bastion.tf
to usebastion_sku
variable.bastion_sku
variable tocore/terraform/variables.tf
with default valueDeveloper
.bastion_sku
variable toconfig_schema.json
.bastion_sku
variable indocs/tre-admins/environment-variables.md
.For more details, open the Copilot Workspace session.