Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E2E Extended tests by adding admin_username override. #4397

Merged
merged 9 commits into from
Feb 24, 2025

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Feb 21, 2025

Updated the deployment process to require a valid user instead of a service principal, addressing the issue of E2E Extended tests failing. Added an admin_username parameter to enable username to be calculated.

Fixes #4396

Copy link
Member Author

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test-extended

Copy link

github-actions bot commented Feb 21, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit da14bf7.

♻️ This comment has been updated with latest results.

@marrobi
Copy link
Member Author

marrobi commented Feb 21, 2025

/test-extended

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13459825935 (with refid 4ebc4385)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Feb 21, 2025

If this works, need to do Linux too.

@marrobi
Copy link
Member Author

marrobi commented Feb 21, 2025

/test-extended

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13464047928 (with refid 4ebc4385)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Feb 21, 2025

/test-extended

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13464828303 (with refid 4ebc4385)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Feb 22, 2025

/test-extended

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13471696441 (with refid 4ebc4385)

(in response to this comment from @marrobi)

@marrobi marrobi requested a review from jonnyry February 23, 2025 12:39
@marrobi marrobi marked this pull request as ready for review February 23, 2025 12:39
@marrobi marrobi requested a review from LizaShak February 24, 2025 09:25
@marrobi marrobi requested a review from yuvalyaron February 24, 2025 13:09
@marrobi
Copy link
Member Author

marrobi commented Feb 24, 2025

@marrobi marrobi enabled auto-merge (squash) February 24, 2025 15:40
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit da14bf7)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 9decbd7 into microsoft:main Feb 24, 2025
12 checks passed
@marrobi marrobi deleted the marrobi/issue4396 branch February 25, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E Extended tests failing as service principal does not exist as a user in AD
3 participants