Refactor the evaluation results handling and upload to Braintrust#67
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the evaluation results handling by extracting the result-related functionality from bcbench.evaluate into a new bcbench.results module, and introduces a new CLI command group for result operations. The changes improve code organization and add support for exporting results to bceval format with Braintrust integration.
Key changes:
- Moved
EvaluationResultandEvaluationResultSummaryfromevaluate/evaluation_result.pytoresults/evaluation_result.py - Split display logic into dedicated
results/display.pymodule - Added
results/result_writer.pyfor bceval format export - Moved
evaluate summarizecommand to newresult summarizecommand incommands/result.py - Updated config to dynamically load instance pattern from dataset schema for result file filtering
- Added Braintrust upload step to GitHub workflow with bceval integration
Reviewed Changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/bcbench/results/evaluation_result.py | New location for EvaluationResult and EvaluationResultSummary classes with from_json and from_results factory methods |
| src/bcbench/results/display.py | Extracted display logic (console and GitHub summaries) into dedicated module |
| src/bcbench/results/result_writer.py | New module for writing results in bceval format |
| src/bcbench/results/init.py | Public API exports for results module |
| src/bcbench/commands/result.py | New CLI command group with result summarize command |
| src/bcbench/config.py | Added dynamic instance_pattern loading from dataset schema and result_pattern to FilePatternConfig |
| tests/test_evaluation_summary.py | Updated tests to use new module paths and EvaluationResult objects instead of raw dicts |
| src/bcbench/evaluate/evaluation_pipeline.py | Updated imports and result file naming to use config pattern |
| docs/_data/results.json | Added leaderboard results data |
| evaluator/scores.py | New bceval evaluator for resolution rate metric |
| .github/workflows/*.yml | Updated workflows to use new result summarize command and added Braintrust integration |
…tures/result-collection-upload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring the evaluation result into a different module with some improvements, address some other concerns along the way:
The eval results should be uploaded to:
bcevalResults are summarized into
evaluation_summary.json