-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing Permissions with Overwrite Option #3184
Importing Permissions with Overwrite Option #3184
Conversation
@stkillen, could you give this a review? |
src/System Application/App/Permission Sets/src/xmlports/ImportPermissionSets.xmlport.al
Outdated
Show resolved
Hide resolved
src/System Application/App/Permission Sets/src/xmlports/ImportPermissionSets.xmlport.al
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please resolve the comments and fix the build errors before we can merge.
src/System Application/App/Permission Sets/src/xmlports/ImportPermissionSets.xmlport.al
Outdated
Show resolved
Hide resolved
src/System Application/App/Permission Sets/src/xmlports/ImportPermissionSets.xmlport.al
Outdated
Show resolved
Hide resolved
5360ed4
to
ad408b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-running build and tests
Summary
With this change, I have enabled the user to be able to overwrite permission sets contained in the import file. Up until now, the permissions from the import file were merged with the permissions already present in the permission sets.
The majority of changes were done in this repo but the text for a confirmation dialog has been changed in the repo containing the Base App
https://github.com/microsoft/BusinessCentralApps/pull/1287
Description of the problem
Importing user defined permissions sets leaves permissions in inconsistent state.
Users tend to test the permissions sets in multiple rounds in a test system. After they are satisfied with the result they decide to import it in a production. However the outcome of the import is not reliable. Users would like to overwrite current user defined permission set with preserving assignment to the users/security groups. Currently if a permission set is imported there are two problems:
That means that importing permission sets is basically "additive" and can only give more "power". There is no easy way to import XX permission sets that are already assigned to users or security groups and that those are imported "as is" in the import file.
Work Item(s)
Fixes #3162
Fixes AB#559224