Fixes #3034

[DrieVeertien]

Summary

Changed EmailScenarioAttachments record to be by var in an event to be able to set filters.

Work Item(s)

Fixes #3034

Fixes AB#568527

[DrieVeertien]

@JesperSchulz
Is this correct? I can't get past the check for AB#... Because I don't know the Azure Board work item. I tried it with the Issue number and now I think a wrong AB item is linked to this issue. I removed it but maybe the link is still there. Do I need to do something?

Run build/scripts/PullRequestValidation/ValidateInternalWorkItemForPullRequest.ps1 -PullRequestNumber 3186 -Repository microsoft/BCApps
Validating PR 3186
Exception: /home/runner/work/BCApps/BCApps/build/scripts/PullRequestValidation/ValidateInternalWorkItemForPullRequest.ps1:39
Line |
39 | throw $Comment
| ~~~~~~~~~~~~~~
| Could not find a linked ADO work item. Please link one by using the
| pattern 'AB#' followed by the relevant work item number. You may use the
| 'Fixes' keyword to automatically resolve the work item when the pull
| request is merged. E.g. 'Fixes AB#1234'
Error: Process completed with exit code 1.

[JesperSchulz]

@DrieVeertien, don't worry about the AB work item 😊 When this PR is ready, I will create one for us internally. Let's get this PR reviewed!

[JesperSchulz]

@aholstrup1, the AS0077 rule should not be active on the main branch. It should only be active on release branches. For major and minor releases, you are allowed to add the var modifier to parameters. In release branches you may not, as apps aren't recompiled and the change will lead to runtime errors.
This PR fails on AS0077. Could we get that addressed?

[JesperSchulz]

#3201 created to take care of rule AS0077.

[JesperSchulz]

Trying CI again. Rule has been disabled.

[JesperSchulz]

@DrieVeertien, could you pull from the main branch? We need the latest updates in this PR.

[DrieVeertien]

@JesperSchulz I merged this PR with main.

[JesperSchulz]

Need to disable notoriously unstable REST Client tests, which depend on an external service. Once disabled, we'll try this once more. Getting there ;-)