Skip to content

Fixes #3034#3186

Merged
JesperSchulz merged 2 commits intomicrosoft:mainfrom
DrieVeertien:fp_fix_for_Issue-3034
Mar 20, 2025
Merged

Fixes #3034#3186
JesperSchulz merged 2 commits intomicrosoft:mainfrom
DrieVeertien:fp_fix_for_Issue-3034

Conversation

@DrieVeertien
Copy link
Contributor

@DrieVeertien DrieVeertien commented Mar 5, 2025 •
edited by github-actions bot
Loading

Summary

Changed EmailScenarioAttachments record to be by var in an event to be able to set filters.

Work Item(s)

Fixes #3034

Fixes AB#568527

@DrieVeertien DrieVeertien requested a review from a team as a code owner March 5, 2025 16:07
@github-actions github-actions bot added AL: System Application From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item labels Mar 5, 2025
@github-actions github-actions bot added this to the Version 27.0 milestone Mar 5, 2025
@DrieVeertien
Copy link
Contributor Author

DrieVeertien commented Mar 5, 2025

@JesperSchulz
Is this correct? I can't get past the check for AB#... Because I don't know the Azure Board work item. I tried it with the Issue number and now I think a wrong AB item is linked to this issue. I removed it but maybe the link is still there. Do I need to do something?

Run build/scripts/PullRequestValidation/ValidateInternalWorkItemForPullRequest.ps1 -PullRequestNumber 3186 -Repository microsoft/BCApps
Validating PR 3186
Exception: /home/runner/work/BCApps/BCApps/build/scripts/PullRequestValidation/ValidateInternalWorkItemForPullRequest.ps1:39
Line |
39 | throw $Comment
| ~~~~~~~~~~~~~~
| Could not find a linked ADO work item. Please link one by using the
| pattern 'AB#' followed by the relevant work item number. You may use the
| 'Fixes' keyword to automatically resolve the work item when the pull
| request is merged. E.g. 'Fixes AB#1234'
Error: Process completed with exit code 1.

@JesperSchulz
Copy link
Contributor

JesperSchulz commented Mar 6, 2025

@DrieVeertien, don't worry about the AB work item 😊 When this PR is ready, I will create one for us internally. Let's get this PR reviewed!

@JesperSchulz JesperSchulz added Integration GitHub request for Integration area and removed Linked Issue is linked to a Azure Boards work item labels Mar 6, 2025
@JesperSchulz
Copy link
Contributor

JesperSchulz commented Mar 6, 2025

@aholstrup1, the AS0077 rule should not be active on the main branch. It should only be active on release branches. For major and minor releases, you are allowed to add the var modifier to parameters. In release branches you may not, as apps aren't recompiled and the change will lead to runtime errors.
This PR fails on AS0077. Could we get that addressed?

@JesperSchulz JesperSchulz added the Linked Issue is linked to a Azure Boards work item label Mar 6, 2025
@JesperSchulz JesperSchulz self-assigned this Mar 10, 2025
@JesperSchulz JesperSchulz added the Follow Up The issue has an open question and must be followed up on label Mar 10, 2025
@JesperSchulz
Copy link
Contributor

JesperSchulz commented Mar 10, 2025

#3201 created to take care of rule AS0077.

@JesperSchulz
Copy link
Contributor

JesperSchulz commented Mar 11, 2025

Trying CI again. Rule has been disabled.

@JesperSchulz
Copy link
Contributor

JesperSchulz commented Mar 13, 2025

@DrieVeertien, could you pull from the main branch? We need the latest updates in this PR.

@DrieVeertien
Copy link
Contributor Author

DrieVeertien commented Mar 13, 2025

@JesperSchulz I merged this PR with main.

@JesperSchulz JesperSchulz removed the Follow Up The issue has an open question and must be followed up on label Mar 19, 2025
@JesperSchulz
Copy link
Contributor

JesperSchulz commented Mar 19, 2025

Need to disable notoriously unstable REST Client tests, which depend on an external service. Once disabled, we'll try this once more. Getting there ;-)

@stkillen stkillen mentioned this pull request Mar 20, 2025
Closed
@JesperSchulz JesperSchulz merged commit 15c8e45 into microsoft:main Mar 20, 2025
24 checks passed
@DrieVeertien DrieVeertien deleted the fp_fix_for_Issue-3034 branch March 20, 2025 09:47
JesperSchulz pushed a commit that referenced this pull request Apr 7, 2025
@DrieVeertien @JesperSchulz
Fixes #3034 (#3186)
00e0d49 
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
Changed EmailScenarioAttachments record to be by var in an event to be
able to set filters.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes #3034 






Fixes
[AB#568527](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/568527)

Co-authored-by: Frederik Pas <fp@tcog.be>
@JesperSchulz JesperSchulz mentioned this pull request Apr 7, 2025
Closed
JesperSchulz pushed a commit that referenced this pull request Apr 7, 2025
@DrieVeertien @JesperSchulz
Fixes #3034 (#3186)
7b47952 
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
Changed EmailScenarioAttachments record to be by var in an event to be
able to set filters.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes #3034 






Fixes
[AB#568527](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/568527)

Co-authored-by: Frederik Pas <fp@tcog.be>
@JesperSchulz JesperSchulz mentioned this pull request Apr 7, 2025
Merged
JesperSchulz added a commit that referenced this pull request Apr 8, 2025
@JesperSchulz @DrieVeertien
[26.x] Bug 572343: [26.x][BCApps #3186]Fixes #3034 (#3451)
652f023 
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
Backport of #3186 

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#572343](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/572343)

Co-authored-by: DrieVeertien <144439226+DrieVeertien@users.noreply.github.com>
Co-authored-by: Frederik Pas <fp@tcog.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JesperSchulz JesperSchulz JesperSchulz approved these changes

@stkillen stkillen stkillen approved these changes

Assignees

@JesperSchulz JesperSchulz

Labels

AL: System Application From Fork Pull request is coming from a fork Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item

Projects

None yet

Milestone

Version 27.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Adding Filters to the Email Scenario Attachments before they are retrieved EVENT fix (var)

3 participants

@DrieVeertien @JesperSchulz @stkillen